Skip to content

Conversation

w-k-jones
Copy link
Member

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.53%. Comparing base (ca2f51d) to head (00b4510).

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.6.0     #495   +/-   ##
==========================================
  Coverage      63.53%   63.53%           
==========================================
  Files             27       27           
  Lines           3842     3842           
==========================================
  Hits            2441     2441           
  Misses          1401     1401           
Flag Coverage Δ
unittests 63.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Apr 30, 2025

Linting results by Pylint:

Your code has been rated at 8.31/10 (previous run: 8.31/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.6.0 branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@w-k-jones w-k-jones requested review from freemansw1 and fsenf April 30, 2025 08:46
@w-k-jones
Copy link
Member Author

@freemansw1 @fsenf Let me know if this needs reviewing or if it can be merged straight away

@w-k-jones w-k-jones mentioned this pull request Apr 30, 2025
9 tasks
@w-k-jones w-k-jones self-assigned this May 1, 2025
@w-k-jones w-k-jones added the release Organising the next release on conda-forge label May 1, 2025
@w-k-jones w-k-jones added this to the Version 1.6 milestone May 1, 2025
Copy link
Member

@fsenf fsenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing the release! I am fine with the changes, but did not review notebooks again. I am guessing they were just rerun. Please go ahead and merge!

@w-k-jones w-k-jones merged commit 7876d8f into tobac-project:RC_v1.6.0 May 5, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Organising the next release on conda-forge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants