Skip to content

Conversation

w-k-jones
Copy link
Member

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

freemansw1 and others added 30 commits September 10, 2023 21:37
# Conflicts:
#	tobac/feature_detection.py
…_xarray_work_fd_julia_avgs

# Conflicts:
#	tobac/feature_detection.py
#	tobac/utils/__init__.py
#	tobac/utils/general.py
…_xarray_work_fd_julia_avgs

# Conflicts:
#	tobac/utils/__init__.py
#	tobac/utils/general.py
…y_work_fd_julia_avgs

# Conflicts:
#	tobac/utils/general.py
…y_work_fd_julia_avgs

# Conflicts:
#	tobac/feature_detection.py
#	tobac/utils/internal/xarray_utils.py
… and hdim_2 had to be provided even if only calculating PBCs over one dimension
Fix remaining issues with datetime conversions and coordinate naming for iris/xarray compatibility
…ard name of segmentation field) and update plots in notebooks
Update example notebooks to use xarray
Update version number, changelog and notebooks for v1.6.0 release
Copy link

codecov bot commented May 5, 2025

Codecov Report

❌ Patch coverage is 87.17617% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.53%. Comparing base (3a8ffba) to head (7876d8f).
⚠️ Report is 384 commits behind head on main.

Files with missing lines Patch % Lines
tobac/utils/internal/iris_utils.py 63.88% 52 Missing ⚠️
tobac/utils/internal/xarray_utils.py 87.50% 15 Missing ⚠️
tobac/feature_detection.py 81.96% 11 Missing ⚠️
tobac/plotting.py 31.25% 11 Missing ⚠️
tobac/utils/bulk_statistics.py 82.35% 3 Missing ⚠️
tobac/utils/internal/coordinates.py 96.20% 3 Missing ⚠️
tobac/utils/general.py 90.47% 2 Missing ⚠️
tobac/segmentation/watershed_segmentation.py 97.61% 1 Missing ⚠️
tobac/wrapper.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   60.44%   63.53%   +3.08%     
==========================================
  Files          23       27       +4     
  Lines        3522     3842     +320     
==========================================
+ Hits         2129     2441     +312     
- Misses       1393     1401       +8     
Flag Coverage Δ
unittests 63.53% <87.17%> (+3.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented May 5, 2025

Linting results by Pylint:

Your code has been rated at 8.24/10 (previous run: 8.24/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the main branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@w-k-jones w-k-jones mentioned this pull request May 1, 2025
9 tasks
@w-k-jones w-k-jones merged commit d277bc1 into main May 5, 2025
44 checks passed
@w-k-jones w-k-jones deleted the RC_v1.6.0 branch May 5, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants