Skip to content

fix(nbstore): fix cloud blob in ios and android #11938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Apr 23, 2025

No description provided.

@EYHN EYHN marked this pull request as ready for review April 23, 2025 12:19
@graphite-app graphite-app bot requested review from a team April 23, 2025 12:19
Copy link
Member Author

EYHN commented Apr 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.93%. Comparing base (ff133d1) to head (a321043).

Files with missing lines Patch % Lines
...s/backend/server/src/core/workspaces/controller.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary   #11938   +/-   ##
=======================================
  Coverage   55.92%   55.93%           
=======================================
  Files        2578     2578           
  Lines      114909   114914    +5     
  Branches    18542    18543    +1     
=======================================
+ Hits        64262    64273   +11     
+ Misses      49285    49276    -9     
- Partials     1362     1365    +3     
Flag Coverage Δ
server-test 79.19% <83.33%> (+<0.01%) ⬆️
unittest 31.39% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EYHN EYHN force-pushed the eyhn/fix/ios-blob branch from d07ed05 to a321043 Compare April 23, 2025 12:26
@graphite-app graphite-app bot requested a review from a team April 23, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants