Skip to content
This repository was archived by the owner on Jun 9, 2021. It is now read-only.

Commit 10becd4

Browse files
committed
Removing falty code left from #128
1 parent d07caf8 commit 10becd4

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Changelog of Pull Request Notifier for Bitbucket.
44

5-
## Unreleased
5+
## 2.29
66
### GitHub [#129](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/129) Unable to use wildcard for 'Repository'
77
Avoiding crash when administring global admin page as admin
88

@@ -13,7 +13,7 @@ Changelog of Pull Request Notifier for Bitbucket.
1313
### GitHub [#130](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/130) Cannot delete Buttons or Notifications
1414
Correcting deletion of buttons on repo level
1515

16-
[3ae702f86765ec4](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/3ae702f86765ec4) Tomas Bjerre *2016-07-06 04:44:14*
16+
[60c84463ee5d38a](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/60c84463ee5d38a) Tomas Bjerre *2016-07-06 19:59:41*
1717

1818
## 2.28
1919
### No issue

src/main/resources/pr-triggerbutton.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,8 @@ define('plugin/prnfb/pr-triggerbutton', [
1212
$(".triggerManualNotification").remove();
1313

1414
function loadSettingsAndShowButtons() {
15-
var hasButtons = false;
1615
$.get(buttonsAdminUrl + '/repository/' + pageState.getRepository().id + '/pullrequest/' + pageState.getPullRequest().id, function(settings) {
1716
settings.forEach(function(item) {
18-
hasButtons = true;
19-
2017
var $buttonDropdownItem = $('<li><button class="aui-button aui-button-link" role="menuitem">' + item.name + '</button></li>');
2118
$buttonDropdownItem.find("button").click(function() {
2219
var $this = $(this);
@@ -36,9 +33,6 @@ define('plugin/prnfb/pr-triggerbutton', [
3633
$buttonArea.append($buttonDropdownItem);
3734
});
3835

39-
if (hasButtons) {
40-
$buttonDropdownParent.show();
41-
}
4236
});
4337
}
4438

@@ -47,7 +41,6 @@ define('plugin/prnfb/pr-triggerbutton', [
4741
//If a reviewer approves the PR, then a button may become visible
4842
$('.aui-button.approve').click(function() {
4943
setTimeout(function() {
50-
$buttonDropdownParent.hide();
5144
loadSettingsAndShowButtons();
5245
}, 1000);
5346
});

0 commit comments

Comments
 (0)