Not logging authorization header value #106

tomasbjerre · tomasbjerre · commit 40f865254133 · 2016-03-14T17:03:54.000+01:00
diff --git a/src/main/java/se/bjurr/prnfb/http/UrlInvoker.java b/src/main/java/se/bjurr/prnfb/http/UrlInvoker.java
@@ -342,7 +342,13 @@ public boolean isTrusted(X509Certificate[] chain, String authType) {
 
  private void addHeaders(HttpRequestBase httpRequestBase) {
   for (Header header : headers) {
-   logger.fine("header: \"" + header.getName() + "\" value: \"" + header.getValue() + "\"");
+
+   if (header.getName().equals(AUTHORIZATION)) {
+    logger.fine("header: \"" + header.getName() + "\" value: \"**********\"");
+   } else {
+    logger.fine("header: \"" + header.getName() + "\" value: \"" + header.getValue() + "\"");
+   }
+
    httpRequestBase.addHeader(header.getName(), getHeaderValue(header));
   }
  }

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,13 @@ public boolean isTrusted(X509Certificate[] chain, String authType) {`
`342`	`342`
`343`	`343`	`private void addHeaders(HttpRequestBase httpRequestBase) {`
`344`	`344`	`for (Header header : headers) {`
`345`		`- logger.fine("header: \"" + header.getName() + "\" value: \"" + header.getValue() + "\"");`
	`345`	`+`
	`346`	`+ if (header.getName().equals(AUTHORIZATION)) {`
	`347`	`+ logger.fine("header: \"" + header.getName() + "\" value: \"**********\"");`
	`348`	`+ } else {`
	`349`	`+ logger.fine("header: \"" + header.getName() + "\" value: \"" + header.getValue() + "\"");`
	`350`	`+ }`
	`351`	`+`
`346`	`352`	`httpRequestBase.addHeader(header.getName(), getHeaderValue(header));`
`347`	`353`	`}`
`348`	`354`	`}`