Skip to content
This repository was archived by the owner on Jun 9, 2021. It is now read-only.

Commit 4761aa5

Browse files
committed
Defaulting proxy port to null
1 parent 807d483 commit 4761aa5

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,18 @@
33
Changelog of Pull Request Notifier for Bitbucket.
44

55
## Unreleased
6+
### GitHub [#116](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/116) Not saving configuration
7+
Linting with JSHint
8+
9+
* Found JS that may crashes in IE9.
10+
11+
[807d483c0c9b9f9](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/807d483c0c9b9f9) Tomas Bjerre *2016-05-12 16:04:16*
12+
613
### No issue
14+
Defaulting proxy port to null
15+
16+
[b47ee2751e43fdf](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/b47ee2751e43fdf) Tomas Bjerre *2016-05-12 16:18:16*
17+
718
doc
819

920
[6e92abeebfaae7b](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/6e92abeebfaae7b) Tomas Bjerre *2016-05-11 15:36:41*

src/main/java/se/bjurr/prnfb/settings/PrnfbNotification.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public PrnfbNotification(PrnfbNotificationBuilder builder) throws ValidationExce
5050
this.proxyUser = emptyToNull(nullToEmpty(builder.getProxyUser()).trim());
5151
this.proxyPassword = emptyToNull(nullToEmpty(builder.getProxyPassword()).trim());
5252
this.proxyServer = emptyToNull(nullToEmpty(builder.getProxyServer()).trim());
53-
this.proxyPort = firstNonNull(builder.getProxyPort(), -1);
53+
this.proxyPort = builder.getProxyPort();
5454
this.headers = checkNotNull(builder.getHeaders());
5555
this.postContent = emptyToNull(nullToEmpty(builder.getPostContent()).trim());
5656
this.method = firstNonNull(builder.getMethod(), GET);

0 commit comments

Comments
 (0)