Button not displaying on PRs which are merged

[itay]

We have a trigger that is configured like this:

I can see the API returning it:

However, it's not being rendered:

Any idea what might be happening?

[tomasbjerre]

Which version of Bitbucket Server is that?

[itay]

4.11.1

[tomasbjerre]

No errors in the console tab of developer tools?
Do you have other buttons that are working with 4.11.1?

[tomasbjerre]

Now I see it!

I just released 2.54 that changes the "state" label to "Ignore if". Which is what those 2 checkboxes does. They ignore the notification if the PR is merged/declined.

[ahadiwijaya]

@tomasbjerre Was the fix just the label? I tried changing the configuration by unchecking the "State" (="Ignore if") conditions, and the issue still persists - the button is not appearing for merged PRs.

The button is not appearing for PRs that have been merged:

And I can also see the API returning the button data:

However, it is appearing for non-merged PRs:

[tomasbjerre]

Yes that was the only change.

Perhaps the problem is a conflict with the Webhook to Jenkins plugin. If you disable that plugin, does the button from this plugin show up correctly also for unmerged PR:s?

[ahadiwijaya]

@tomasbjerre I believe the Webhook to Jenkins plugin has always been disabled for the repository - do you know what else could affect this?

[tomasbjerre]

The "Trigger Notification" -button in your first screenshot, is that not from the Webhook to Jenkins plugin?

[ahadiwijaya]

I think it's from PR notifier (?) Please correct me if I'm wrong.

WebFragments.addWebItemDescriptor({"completeModuleKey":"se.bjurr.prnfs.pull-request-notifier-for-stash:se.bjurr.prnfb.triggerbutton","key":"se.bjurr.prnfb.triggerbutton","moduleKey":"se.bjurr.prnfb.triggerbutton","params":{},"pluginKey":"se.bjurr.prnfs.pull-request-notifier-for-stash","location":"bitbucket.internal.pullrequest.toolbar.deprecated/bitbucket.pull-request.toolbar.actions","weight":50,"linkText":"Trigger Notification","styleClass":"triggerManualNotification"});

This fragment appears both on the merged and non-merged PRs, but I only see it as a button on merged PRs.

[tomasbjerre]

Ok I will probably have some time to look at this tomorrow. Thanks for the info!

[ahadiwijaya]

Thanks @tomasbjerre !