Skip to content

Commit 7b07646

Browse files
committed
Merge remote-tracking branch 'origin/main' into wasm
2 parents 4d34932 + 453ba81 commit 7b07646

File tree

6 files changed

+19
-21
lines changed

6 files changed

+19
-21
lines changed

src/compaction/mod.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ use futures_util::StreamExt;
66
use parquet::arrow::{AsyncArrowWriter, ProjectionMask};
77
use thiserror::Error;
88
use tokio::sync::oneshot;
9-
use ulid::Ulid;
109

1110
use crate::{
1211
fs::{manager::StoreManager, FileId, FileType},
@@ -546,7 +545,7 @@ where
546545
debug_assert!(min.is_some());
547546
debug_assert!(max.is_some());
548547

549-
let gen = Ulid::new();
548+
let gen = FileId::new();
550549
let columns = builder.finish(None);
551550
let schema = instance.arrow_schema::<R>().clone();
552551
#[cfg(feature = "opfs")]

src/inmem/mutable.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ use crossbeam_skiplist::{
66
SkipMap,
77
};
88
use fusio::{buffered::BufWriter, DynFs, DynWrite};
9-
use ulid::Ulid;
109

1110
use crate::{
1211
fs::{DynWriteWrapper, FileId, FileType},
@@ -52,7 +51,7 @@ where
5251
) -> Result<Self, fusio::Error> {
5352
let mut wal = None;
5453
if option.use_wal {
55-
let file_id = Ulid::new();
54+
let file_id = FileId::new();
5655

5756
let file = Box::new(BufWriter::new(
5857
fs.open_options(

src/lib.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -618,14 +618,15 @@ where
618618
}
619619

620620
/// scan configuration intermediate structure
621-
pub struct Scan<'scan, R>
621+
pub struct Scan<'scan, 'range, R>
622622
where
623623
R: Record,
624+
'range: 'scan,
624625
{
625626
schema: &'scan Schema<R>,
626627
manager: Arc<StoreManager>,
627-
lower: Bound<&'scan R::Key>,
628-
upper: Bound<&'scan R::Key>,
628+
lower: Bound<&'range R::Key>,
629+
upper: Bound<&'range R::Key>,
629630
ts: Timestamp,
630631

631632
version: &'scan Version<R>,
@@ -637,14 +638,14 @@ where
637638
projection: ProjectionMask,
638639
}
639640

640-
impl<'scan, R> Scan<'scan, R>
641+
impl<'scan, 'range, R> Scan<'scan, 'range, R>
641642
where
642643
R: Record + Send,
643644
{
644645
fn new(
645646
schema: &'scan Schema<R>,
646647
manager: Arc<StoreManager>,
647-
(lower, upper): (Bound<&'scan R::Key>, Bound<&'scan R::Key>),
648+
(lower, upper): (Bound<&'range R::Key>, Bound<&'range R::Key>),
648649
ts: Timestamp,
649650
version: &'scan Version<R>,
650651
fn_pre_stream: Box<

src/scope.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,16 +160,15 @@ where
160160
mod test {
161161
use std::ops::Bound;
162162

163-
use ulid::Ulid;
164-
165163
use super::Scope;
164+
use crate::fs::FileId;
166165

167166
#[tokio::test]
168167
async fn test_meets_range() {
169168
let scope = Scope {
170169
min: 100,
171170
max: 200,
172-
gen: Ulid::new(),
171+
gen: FileId::new(),
173172
wal_ids: None,
174173
};
175174

src/snapshot.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ impl<'s, R: Record> Snapshot<'s, R> {
3939
}))
4040
}
4141

42-
pub fn scan<'scan>(
42+
pub fn scan<'scan, 'range>(
4343
&'scan self,
44-
range: (Bound<&'scan R::Key>, Bound<&'scan R::Key>),
45-
) -> Scan<'scan, R> {
44+
range: (Bound<&'range R::Key>, Bound<&'range R::Key>),
45+
) -> Scan<'scan, 'range, R> {
4646
Scan::new(
4747
&self.share,
4848
self.manager.clone(),
@@ -78,13 +78,13 @@ impl<'s, R: Record> Snapshot<'s, R> {
7878
&self.share
7979
}
8080

81-
pub(crate) fn _scan<'scan>(
81+
pub(crate) fn _scan<'scan, 'range>(
8282
&'scan self,
83-
range: (Bound<&'scan R::Key>, Bound<&'scan R::Key>),
83+
range: (Bound<&'range R::Key>, Bound<&'range R::Key>),
8484
fn_pre_stream: Box<
8585
dyn FnOnce(Option<ProjectionMask>) -> Option<ScanStream<'scan, R>> + Send + 'scan,
8686
>,
87-
) -> Scan<'scan, R> {
87+
) -> Scan<'scan, 'range, R> {
8888
Scan::new(
8989
&self.share,
9090
self.manager.clone(),

src/transaction.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@ where
8181
}
8282

8383
/// scan records with primary keys in the `range`
84-
pub fn scan<'scan>(
84+
pub fn scan<'scan, 'range>(
8585
&'scan self,
86-
range: (Bound<&'scan R::Key>, Bound<&'scan R::Key>),
87-
) -> Scan<'scan, R> {
86+
range: (Bound<&'range R::Key>, Bound<&'range R::Key>),
87+
) -> Scan<'scan, 'range, R> {
8888
self.snapshot._scan(
8989
range,
9090
Box::new(move |projection_mask: Option<ProjectionMask>| {

0 commit comments

Comments
 (0)