fix: open version log clear content #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crwen
commented
May 29, 2025
| @@ -259,7 +259,7 @@ where | |||
| guard.current = Arc::new(new_version); | |||
|
|
|||
| drop(guard); | |||
| if edit_len >= option.version_log_snapshot_threshold { | |||
| if edit_len >= option.version_log_snapshot_threshold || is_recover { | |||
There was a problem hiding this comment.
I think it's better to rewrite manifest file when open db. If you don't think so, I'll remove this change
ethe
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #295 , we open manifest file with truncate option because only truncate mode is supported by S3.
But when open file with truncate mode, the content will be clear. So I think we can remove the truncate option for now. For S3 case, we can wait for #327 . If you think this is ok I'll pull another PR to fix this problem in wal.