chore: add sample images, lib private constructors

Author: topotopo

app/build.gradle

@@ -35,6 +35,7 @@ android {
         enabled = true
     }
     repositories {
+        mavenCentral()
         jcenter()
     }
     compileOptions {
@@ -74,4 +75,7 @@ dependencies {
     implementation 'androidx.lifecycle:lifecycle-livedata-ktx:2.2.0-rc02'
 
     implementation project(':commonadapter')
+    
+    implementation 'com.github.bumptech.glide:glide:4.11.0'
+    annotationProcessor 'com.github.bumptech.glide:compiler:4.11.0'
 }

app/src/main/java/com/mmicu/demo/feed/presentation/FeedFragment.kt

@@ -11,6 +11,7 @@ import androidx.lifecycle.Observer
 import androidx.recyclerview.widget.LinearLayoutManager
 import com.mmicu.commonadapter.CommonItemHolder
 import com.mmicu.commonadapter.CommonRecyclerViewAdapter
+import com.mmicu.commonadapter.CommonRecyclerViewAdapterImpl
 import com.mmicu.demo.R
 import com.mmicu.demo.core.AppRecyclerViewAdapter
 import com.mmicu.demo.databinding.FragmentFeedBinding
@@ -22,7 +23,7 @@ class FeedFragment : Fragment(),
 
     private val sampleMovieList = mutableListOf<CommonItemHolder<*>>()
     private lateinit var binding: FragmentFeedBinding
-    private lateinit var recyclerViewAdapterImpl: CommonRecyclerViewAdapter
+    private lateinit var recyclerViewAdapter: CommonRecyclerViewAdapter
 
     private val feedViewModel: FeedViewModel by sharedViewModel()
 
@@ -40,12 +41,12 @@ class FeedFragment : Fragment(),
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-
-        recyclerViewAdapterImpl = AppRecyclerViewAdapter(
+        
+        recyclerViewAdapter = AppRecyclerViewAdapter(
             sampleMovieList
         )
 
-        recyclerViewAdapterImpl.setItemClickListener { pos, data, view ->
+        recyclerViewAdapter.setItemClickListener { pos, data, view ->
             Toast.makeText(
                 context,
                 "Item clicked $pos",
@@ -54,7 +55,7 @@ class FeedFragment : Fragment(),
         }
         binding.rvFeed.layoutManager =
             LinearLayoutManager(context)
-        binding.rvFeed.adapter = recyclerViewAdapterImpl
+        binding.rvFeed.adapter = recyclerViewAdapter
 
         addObservers()
     }
@@ -63,7 +64,7 @@ class FeedFragment : Fragment(),
         feedViewModel.feedList.observe(this, Observer {
             sampleMovieList.clear()
             sampleMovieList.addAll(it)
-            recyclerViewAdapterImpl.notifyDataSetChanged()
+            recyclerViewAdapter.notifyDataSetChanged()
         })
     }
 }

app/src/main/java/com/mmicu/demo/feed/presentation/itemviewholder/CommonItems.kt

@@ -1,16 +1,29 @@
 package com.mmicu.demo.feed.presentation.itemviewholder
 
+import android.view.View
+import com.bumptech.glide.Glide
 import com.mmicu.demo.R
 import com.mmicu.demo.feed.domain.model.MovieModel
 import com.mmicu.demo.feed.domain.model.StatusModel
 import com.mmicu.commonadapter.CommonItemHolder
+import kotlinx.android.synthetic.main.item_feed_movie.view.*
 
 data class MovieFeedItemHolder(
     override var data: MovieModel?,
     override var layoutId: Int = R.layout.item_feed_movie,
     override var variableId: Int?
 ) :
-    CommonItemHolder<MovieModel>
+    CommonItemHolder<MovieModel> {
+    override fun onBindViewHolder(itemView: View) {
+        super.onBindViewHolder(itemView)
+
+        Glide
+            .with(itemView)
+            .load(data?.imageUrl)
+            .centerCrop()
+            .into(itemView.feedImage)
+    }
+}
 
 data class StatusFeedItemHolder(
     override var data: StatusModel?,

app/src/main/res/layout/item_feed_movie.xml

@@ -23,6 +23,7 @@
             android:orientation="vertical">
 
             <ImageView
+                android:id="@+id/feedImage"
                 android:layout_width="match_parent"
                 android:layout_height="@dimen/feed_img_height"
                 android:background="@android:color/darker_gray"

app/src/main/res/raw/fetch_feed_response.json

@@ -3,7 +3,7 @@
     {
       "id": "0",
       "title": "Parasite",
-      "imageUrl": "",
+      "imageUrl": "https://miro.medium.com/max/1400/1*cNkte5WPBwnr3jFqetb5gA.jpeg",
       "description": "All unemployed, Ki-taek and his family take peculiar interest in the wealthy and glamorous Parks, as they ingratiate themselves into their lives and get entangled in an unexpected incident.",
       "type": "movie"
     },
@@ -16,14 +16,14 @@
     {
       "id": "2",
       "title": "Little Women",
-      "imageUrl": "",
+      "imageUrl": "https://consequenceofsound.net/wp-content/uploads/2019/08/greta-gerwig-little-women.jpg",
       "description": "Jo March reflects back and forth on her life, telling the beloved story of the March sisters - four young women each determined to live life on their own terms.",
       "type": "movie"
     },
     {
       "id": "3",
       "title": "1917",
-      "imageUrl": "",
+      "imageUrl": "https://m.media-amazon.com/images/M/MV5BMGQ0N2Y3MzQtNWVhYi00OWYwLWFlZmQtYTkyOTliYzI4YzJmXkEyXkFqcGdeQWFybm8@._V1_.jpg",
       "description": "Two young British soldiers during the First World War are given an impossible mission: deliver a message deep in enemy territory that will stop 1,600 men, and one of the soldiers' brothers, from walking straight into a deadly trap.",
       "type": "movie"
     },

commonadapter/src/main/java/com/mmicu/commonadapter/CommonRecyclerViewAdapter.kt

@@ -13,7 +13,7 @@ abstract class CommonRecyclerViewAdapter(
     listCommonHolder: MutableList<CommonItemHolder<*>>
 ) : RecyclerView.Adapter<CommonViewHolder>() {
 
-    private val commonRecyclerViewAdapter = CommonRecyclerViewAdapterImpl(listCommonHolder)
+    private val commonRecyclerViewAdapter = CommonRecyclerViewAdapterImpl.initialize(listCommonHolder)
 
     /**
      * Sets a listener invoked when an item is clicked

commonadapter/src/main/java/com/mmicu/commonadapter/CommonRecyclerViewAdapterImpl.kt

@@ -6,10 +6,16 @@ import android.view.ViewGroup
 import androidx.databinding.DataBindingUtil
 import androidx.databinding.ViewDataBinding
 
-internal class CommonRecyclerViewAdapterImpl(
+class CommonRecyclerViewAdapterImpl private constructor(
     private val listCommonHolder: MutableList<CommonItemHolder<*>>
 ) {
 
+    companion object {
+        fun initialize(listCommonHolder: MutableList<CommonItemHolder<*>>): CommonRecyclerViewAdapterImpl {
+            return CommonRecyclerViewAdapterImpl(listCommonHolder)
+        }
+    }
+
     private lateinit var onItemClickListener: (pos: Int, data: Any?, view: View) -> Unit
 
     fun setItemClickListener(onItemClickListener: (pos: Int, data: Any?, view: View) -> Unit) {
@@ -22,7 +28,7 @@ internal class CommonRecyclerViewAdapterImpl(
         val binding: ViewDataBinding = DataBindingUtil.inflate(
             layoutInflater, viewType, parent, false
         )
-        return CommonViewHolderImpl(binding)
+        return CommonViewHolderImpl.initialize(binding)
     }
 
     fun getItemCount(): Int {

commonadapter/src/main/java/com/mmicu/commonadapter/CommonViewHolder.kt

@@ -3,7 +3,7 @@ package com.mmicu.commonadapter
 import androidx.databinding.ViewDataBinding
 import androidx.recyclerview.widget.RecyclerView
 
-abstract class CommonViewHolder(private val binding: ViewDataBinding) :
+abstract class CommonViewHolder(binding: ViewDataBinding) :
     RecyclerView.ViewHolder(binding.root) {
 
     abstract fun bind(commonItemHolder: CommonItemHolder<*>)

commonadapter/src/main/java/com/mmicu/commonadapter/CommonViewHolderImpl.kt

@@ -5,9 +5,15 @@ import androidx.databinding.ViewDataBinding
 /**
  * A generic RecyclerView.ViewHolder for the [CommonRecyclerViewAdapterImpl]
  */
-internal class CommonViewHolderImpl(private val binding: ViewDataBinding) :
+class CommonViewHolderImpl private constructor(private val binding: ViewDataBinding) :
     CommonViewHolder(binding) {
 
+    companion object {
+        fun initialize(binding: ViewDataBinding): CommonViewHolderImpl {
+            return CommonViewHolderImpl(binding)
+        }
+    }
+
     /**
      * Binds the declared model [CommonItemHolder.data]
      * wrapped by [CommonItemHolder] to the layout