Skip to content

Constructive feedback #3

@dermorz

Description

@dermorz

Came here from:
https://www.reddit.com/r/netsec/comments/3g4mr2/nosql_exploitation_framework_v20/

  1. Try to stick to PEP8.
  2. Throw away the install.sh. This is a terrible way of installing python software, because it pollutes existing python installations with modules I would no want there and especially because it can't be installed as a user that way. Instead create a requirements.txt with the needed modules, so it's easy to create a virtualenv to run the frameworkscript. Or even better:
  3. Read up on packaging and distributing python projects and take the necessary steps. After that someone could easily install your framework via pip install nosqlexploitationframework.

Furthermore: Replace your cleanup.sh with a .gitignore file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions