Fix custom HelpFormatter for Python 3.14 #3524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/cpython#132323 passes prefix_chars= (and other arguments) to the formatter_class, but the custom HelpFormatter only accepted prog=. Accept any keyword arguments and pass them on to the parent class. Fixes tox-dev#3523
|
RTD build failure is unrelated: File "/home/docs/checkouts/readthedocs.org/user_builds/tox/checkouts/3524/.tox/docs/lib/python3.13/site-packages/snowballstemmer/__init__.py", line 27, in stemmer
raise KeyError("Stemming algorithm '%s' not found" % lang)
KeyError: "Stemming algorithm 'porter' not found"Test failures seem unrelated too: |
|
GitHub Actions supports 3.14 beta 1 (which is why I saw this error in wntrblm/nox#970), so it could be added to the CI. |
|
The snowball thing is yanked, so that should be fine now. The wheel change is something separate that needs fixing in the tests, probably related to virtualenv. |
|
I'm also seeing this locally: |
hugovk
approved these changes
May 11, 2025
There was a problem hiding this comment.
Thanks, cnfirmed this PR fixes tox on 3.14.
Error before:
https://github.com/hugovk/cherry-picker/actions/runs/14954301375/job/42007915084
Passes with this PR:
https://github.com/hugovk/cherry-picker/actions/runs/14954355501/job/42008033162
(Windows failure is unrelated: python/cpython#133779)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python/cpython#132323 passes prefix_chars= (and other arguments) to the formatter_class, but the custom HelpFormatter only accepted prog=.
Accept any keyword arguments and pass them on to the parent class.
Fixes #3523
tox -e fix)docs/changelogfolder