Skip to content

feat: add backend implementations for Trunc op #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2025
Merged

feat: add backend implementations for Trunc op #3860

merged 5 commits into from
Oct 15, 2025

Conversation

@mooori
Copy link
Contributor

@mooori mooori commented Oct 13, 2025 •
edited
Loading

Pull Request Template

Checklist

  • Confirmed that cargo run-checks command has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Changes

Adds backend implementations for trunc, using native ops where possible.

Depends on this cubecl PR

Testing

Covered by existing trunc tests.

mooori
mooori commented Oct 13, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 11.90476% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.40%. Comparing base (8d95bff) to head (2c09762).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-autodiff/src/ops/tensor.rs 0.00% 23 Missing ⚠️
crates/burn-fusion/src/ops/float.rs 0.00% 17 Missing ⚠️
crates/burn-router/src/ops/op_float.rs 0.00% 11 Missing ⚠️
crates/burn-candle/src/ops/tensor.rs 0.00% 6 Missing ⚠️
crates/burn-fusion/src/stream/context.rs 0.00% 4 Missing ⚠️
crates/burn-ir/src/operation.rs 0.00% 4 Missing ⚠️
crates/burn-cubecl/src/ops/float_ops.rs 0.00% 3 Missing ⚠️
crates/burn-tch/src/ops/tensor.rs 0.00% 3 Missing ⚠️
crates/burn-router/src/runner.rs 0.00% 2 Missing ⚠️
crates/burn-cubecl/src/kernel/unary_float.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3860      +/-   ##
==========================================
- Coverage   64.42%   64.40%   -0.02%     
==========================================
  Files        1167     1167              
  Lines      136126   136225      +99     
==========================================
+ Hits        87694    87732      +38     
- Misses      48432    48493      +61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mooori
Copy link
Contributor Author

mooori commented Oct 13, 2025

Your patch check has failed because the patch coverage (11.90%) is below the target coverage (80.00%)

Isn't the patch indirectly covered by these tests?

@mooori mooori mentioned this pull request Oct 13, 2025
Merged
4 tasks
@mooori mooori marked this pull request as ready for review October 13, 2025 19:07
@nathanielsimard nathanielsimard added the ci:test-gpu When applied to a Pull Request execute the `test-gpu.yml` workflow. label Oct 14, 2025
@laggui
Copy link
Member

laggui commented Oct 15, 2025

Your patch check has failed because the patch coverage (11.90%) is below the target coverage (80.00%)

Isn't the patch indirectly covered by these tests?

Ever since we split our tests into multiple dedicated runners for GPU instances the codecov only checks linux-std-tests, so all of the cubecl/fusion/etc code is "not covered" since it does not run on that runner 😅 been on the TODO list to fix that on the CI but we've had other things to work on hehe

laggui
laggui requested changes Oct 15, 2025
View reviewed changes
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus one tiny mistake

@mooori
Copy link
Contributor Author

mooori commented Oct 15, 2025

Merged latest main (here and in the cubecl PR) and fixed the copy-pasta mistake :)

@mooori mooori requested a review from laggui October 15, 2025 16:02
laggui
laggui approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@laggui laggui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in advance (pending cubecl rev update)

/edit: wgpu/vulkan CI stalls are unrelated

@laggui laggui added ci:test-gpu When applied to a Pull Request execute the `test-gpu.yml` workflow. and removed ci:test-gpu When applied to a Pull Request execute the `test-gpu.yml` workflow. labels Oct 15, 2025
@laggui laggui merged commit f7f2dd5 into tracel-ai:main Oct 15, 2025
12 of 14 checks passed
@antimora
Copy link
Collaborator

antimora commented Oct 15, 2025

Thanks, @mooori.

I suppose we can close #3768 as well?

@antimora antimora mentioned this pull request Oct 15, 2025
Closed
@mooori mooori deleted the trunc-op branch October 17, 2025 06:27
khoek pushed a commit to khoek/burn that referenced this pull request Nov 27, 2025
@mooori @khoek
feat: add backend implementations for Trunc op (tracel-ai#3860)
89f7dbb 
* feat: add backend impls for `trunc`

* Point cubecl dep to PR head

* fix: `float_ceil -> float_trunc`

* Update rev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laggui laggui laggui approved these changes

Assignees

No one assigned

Labels

ci:test-gpu When applied to a Pull Request execute the `test-gpu.yml` workflow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mooori @laggui @antimora @nathanielsimard