Upgrade wgpu #939
Draft
Upgrade wgpu #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently blocked as after gfx-rs/wgpu@b538522, buffers binding size now needs to be 4 byte aligned, which is failing some tests with eg. f16 elements in Burn. The reasoning is here gpuweb/gpuweb#3477 thought it might be removed after all discussed here gpuweb/gpuweb#5203. For now we'd need to pad the binding sizes. This is mostly ok except that for checked kernels it breaks Vulkan robustuness, so would need manual checks there after all. @wingertge proposal is to JIT different kernels depending on whether any of the inputs have padding or not. Unchecked kernels aren't affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate your PR with burn.
It is important that you make sure that you don't introduce any bugs in burn.
Instructions