Skip to content

Conversation

mooori
Copy link
Contributor

@mooori mooori commented Oct 13, 2025

Adds the Trunc op for burn#3768.

On a x86 Linux machine with AMD GPU cargo xtask test --ci passes. I don't have access to an Nvidia GPU and also no HIP setup. Is there any infra to run tests on all supported platforms and runtimes?

If I merged the latest main branch of cubecl, then cargo run-checks in burn runs into compilation errors.

Instructions

  • Create a new branch or fork of the burn repo
  • Update the main Cargo.toml with this PR hash.
  • Fix any broken tests or compilation errors in burn.
  •  Submit a PR in burn with your fixes and link it here.

Here is the PR in burn.

@mooori mooori marked this pull request as ready for review October 13, 2025 19:06
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should be able to merge the latest main changes and update the rev in burn now that the small breaking changes have been merged in burn.

@mooori mooori requested a review from laggui October 15, 2025 16:00
@laggui laggui merged commit a2ba01a into tracel-ai:main Oct 15, 2025
5 checks passed
@mooori mooori deleted the trunc-op branch October 17, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants