Skip to content

Commit f27352a

Browse files
committed
ci: fix broken ci
1 parent 11661d4 commit f27352a

File tree

2 files changed

+5
-18
lines changed

2 files changed

+5
-18
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,16 @@ jobs:
2727

2828
build-and-test:
2929
name: Build and test
30-
runs-on: ubuntu-latest
30+
runs-on: depot-ubuntu-22.04
3131
services:
3232
qdrant:
3333
image: qdrant/qdrant
3434
ports:
3535
- 6333:6333
36+
chroma:
37+
image: chromadb/chromadb
38+
ports:
39+
- 8000:8000
3640
permissions:
3741
contents: "read"
3842
id-token: "write"
@@ -47,8 +51,6 @@ jobs:
4751
cache: "npm"
4852
node-version-file: ".nvmrc"
4953

50-
- run: pip3 install chromadb
51-
5254
- uses: nrwl/nx-set-shas@v3
5355
- run: npm ci
5456
- name: Build

packages/instrumentation-chromadb/tests/instrumentation.test.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ import {
2626
import * as chromadb from "chromadb";
2727
import * as assert from "assert";
2828

29-
import { exec, ChildProcess } from "child_process";
30-
3129
const memoryExporter = new InMemorySpanExporter();
3230

3331
describe("Test ChromaDB instrumentation", function () {
@@ -36,13 +34,8 @@ describe("Test ChromaDB instrumentation", function () {
3634
let contextManager: AsyncHooksContextManager;
3735
let chromaDbClient: chromadb.ChromaClient;
3836
let collection: chromadb.Collection;
39-
let chromaRun: ChildProcess;
4037

4138
this.beforeAll(async () => {
42-
// Run ChromaDB instance on different terminal instance
43-
chromaRun = exec("/bin/sh");
44-
chromaRun.stdin?.write("chroma run --path .\n");
45-
4639
chromaDbClient = new chromadb.ChromaClient();
4740

4841
// Wait for ChromaDB to spin up
@@ -92,14 +85,6 @@ describe("Test ChromaDB instrumentation", function () {
9285
context.disable();
9386
});
9487

95-
after(() => {
96-
// Terminate the Chroma client process after tests
97-
if (chromaRun.pid) {
98-
// DEBT: chromaRun.kill() is not killing spawned process
99-
process.exit(0);
100-
}
101-
});
102-
10388
it("should set span attributes for Query", async () => {
10489
const input: chromadb.QueryParams = {
10590
nResults: 2,

0 commit comments

Comments
 (0)