-
Notifications
You must be signed in to change notification settings - Fork 4
Description
@fontikar I am preparing for re-submission to JStatSoft, and one of their comments was that the hmde_object
class does not have default methods. This is the class assigned to output of the hmde_model function on line 27 of hmde_model.R:
class(output) <- "hmde_object"
The hmde_object
returned is typically used as input for hmde_assign_data, but the latter function does not check if the passed model_template is of the correct type. My question is, do we need to retain this class assignment to preserve good structure in the package? I can write the required functions easily enough.
If we do want to preserve it, I will change the class name to hmde_model_template
, have the assign data function check that it is passed one, and write S3 functions for summary, plot, and print.
@dfalster At present there is no requirement to have S3 methods for the fit object, because it's a stanfit object rather than a custom one. However, it may be useful to do so, so I'm going to create S3 function templates for a hmde_fit
object, and change the output class to it.