Skip to content

Conversation

@ParamThakkar123
Copy link
Contributor

@ParamThakkar123 ParamThakkar123 commented Nov 16, 2025

Fixes #876

Copy link
Member

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce the original error on the main branch by deleting an experiment in app and also in the cloud mode but I wasn't able to reproduce the error. Not sure if it is windows-specific?
Are you able to see it in the cloud mode? (npm run start:cloud)

@ParamThakkar123
Copy link
Contributor Author

I tried to reproduce the original error on the main branch by deleting an experiment in app and also in the cloud mode but I wasn't able to reproduce the error. Not sure if it is windows-specific? Are you able to see it in the cloud mode? (npm run start:cloud)

I got this on the desktop app. Maybe I can send a video of the error on discord ?

@dadmobile
Copy link
Member

I'm OK with adding the check for valid experiments in the app, but I would prefer if we did the filter at the API/SDK level. i.e. inside the function that gets a list of experiments in lab-sdk/ it should verify that fields are correct and print an error message if it finds an experiment missing required fields.

@deep1401 Tagging you in case you have input on if we should filter experiments that are missing experiment_id or experiment_name from their json file? (Param had an experiment that was somehow missing both in its json...no idea how he made it!) Or do you think we should just handle it by adding the ID when listing or something?

Copy link
Member

@dadmobile dadmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in comment...requesting we either add a check for this in SDK (or if we decide these should be handled then make SDK work in this case).

@deep1401
Copy link
Member

I'm OK with adding the check for valid experiments in the app, but I would prefer if we did the filter at the API/SDK level. i.e. inside the function that gets a list of experiments in lab-sdk/ it should verify that fields are correct and print an error message if it finds an experiment missing required fields.

@deep1401 Tagging you in case you have input on if we should filter experiments that are missing experiment_id or experiment_name from their json file? (Param had an experiment that was somehow missing both in its json...no idea how he made it!) Or do you think we should just handle it by adding the ID when listing or something?

I thought I solved this by having a condition in the sdk where if an experiment has a name but no id then it should just use the same name as the id. I'm not sure how to replicate this case but we should for sure do it in the sdk itself in the function which tries to list all experiments.

@ParamThakkar123
Copy link
Contributor Author

Yeah. Got it. I will make a Fix on the sdk instead of on the UI 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error invoking remote method 'setStoreValue': TypeError: Use delete() to clear values

4 participants