Enclose spaces with tx tag so that they are restored as separate strings #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem and/or solution
In pptx, when a paragraph contains one or more empty (only spaces)
a:ttags, it prepents the spaces to the next text element, without creating a new openstring. This could not be handled correctly when compiling the file, which then generates a corrupted pptx file when opened with MS PowerPoint. Enclosing the emptya:ttags with atxtag as we do with other string will retain the correct format of the document. Since this is a braking chacnge, the commonparse_paragraph, compile_paragraphfunctions where moved to thePptxHandlerclass so that only the pptx file format is affected (not docx).How to test
Parse a slide that contains the following paragraph
Reviewer checklist
Code:
PR: