Skip to content

🐛 nit: fix typo in ReturnsTwoToken name #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🐛 nit: fix typo in ReturnsTwoToken name #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d417385
:bug: nit: fix typo in ReturnsTwoToken name
neodaoist Mar 13, 2023
540cf79
snapshot
neodaoist Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .gas-snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ ERC1155Test:testSafeTransferFromToEOA() (gas: 93167)
ERC1155Test:testSafeTransferFromToEOA(uint256,uint256,bytes,uint256,address,bytes) (runs: 256, μ: 93578, ~: 97450)
ERC1155Test:testSafeTransferFromToERC1155Recipient() (gas: 739583)
ERC1155Test:testSafeTransferFromToERC1155Recipient(uint256,uint256,bytes,uint256,bytes) (runs: 256, μ: 769591, ~: 765729)
ERC20Invariants:invariantBalanceSum() (runs: 256, calls: 3840, reverts: 2368)
ERC20Test:invariantMetadata() (runs: 256, calls: 3840, reverts: 2558)
ERC20Invariants:invariantBalanceSum() (runs: 256, calls: 3840, reverts: 2388)
ERC20Test:invariantMetadata() (runs: 256, calls: 3840, reverts: 2610)
ERC20Test:testApprove() (gas: 31058)
ERC20Test:testApprove(address,uint256) (runs: 256, μ: 30424, ~: 31280)
ERC20Test:testBurn() (gas: 56970)
Expand Down Expand Up @@ -146,7 +146,7 @@ ERC20Test:testTransfer() (gas: 60272)
ERC20Test:testTransfer(address,uint256) (runs: 256, μ: 58773, ~: 60484)
ERC20Test:testTransferFrom() (gas: 83777)
ERC20Test:testTransferFrom(address,uint256,uint256) (runs: 256, μ: 86308, ~: 92841)
ERC4626Test:invariantMetadata() (runs: 256, calls: 3840, reverts: 2936)
ERC4626Test:invariantMetadata() (runs: 256, calls: 3840, reverts: 2868)
ERC4626Test:testFailDepositWithNoApproval() (gas: 13357)
ERC4626Test:testFailDepositWithNotEnoughApproval() (gas: 86993)
ERC4626Test:testFailDepositZero() (gas: 7780)
Expand Down Expand Up @@ -313,7 +313,7 @@ OwnedTest:testCallFunctionAsNonOwner(address) (runs: 256, μ: 16252, ~: 16290)
OwnedTest:testCallFunctionAsOwner() (gas: 10435)
OwnedTest:testTransferOwnership() (gas: 13123)
OwnedTest:testTransferOwnership(address) (runs: 256, μ: 13154, ~: 13192)
ReentrancyGuardTest:invariantReentrancyStatusAlways1() (runs: 256, calls: 3840, reverts: 331)
ReentrancyGuardTest:invariantReentrancyStatusAlways1() (runs: 256, calls: 3840, reverts: 266)
ReentrancyGuardTest:testFailUnprotectedCall() (gas: 46147)
ReentrancyGuardTest:testNoReentrancy() (gas: 7515)
ReentrancyGuardTest:testProtectedCall() (gas: 33467)
Expand Down Expand Up @@ -393,7 +393,7 @@ SafeTransferLibTest:testApproveWithGarbage(address,uint256,bytes,bytes) (runs: 2
SafeTransferLibTest:testApproveWithMissingReturn() (gas: 30751)
SafeTransferLibTest:testApproveWithMissingReturn(address,uint256,bytes) (runs: 256, μ: 30328, ~: 31566)
SafeTransferLibTest:testApproveWithNonContract() (gas: 3035)
SafeTransferLibTest:testApproveWithNonContract(address,address,uint256,bytes) (runs: 256, μ: 4121, ~: 4117)
SafeTransferLibTest:testApproveWithNonContract(address,address,uint256,bytes) (runs: 256, μ: 4123, ~: 4117)
SafeTransferLibTest:testApproveWithReturnsTooMuch() (gas: 31134)
SafeTransferLibTest:testApproveWithReturnsTooMuch(address,uint256,bytes) (runs: 256, μ: 30796, ~: 32034)
SafeTransferLibTest:testApproveWithStandardERC20() (gas: 30882)
Expand All @@ -416,7 +416,7 @@ SafeTransferLibTest:testFailTransferFromWithReturnsTooLittle(address,address,uin
SafeTransferLibTest:testFailTransferFromWithReturnsTwo(address,address,uint256,bytes) (runs: 256, μ: 14559, ~: 14554)
SafeTransferLibTest:testFailTransferFromWithReverting() (gas: 9757)
SafeTransferLibTest:testFailTransferFromWithReverting(address,address,uint256,bytes) (runs: 256, μ: 10685, ~: 10680)
SafeTransferLibTest:testFailTransferWithGarbage(address,uint256,bytes,bytes) (runs: 256, μ: 90360, ~: 83989)
SafeTransferLibTest:testFailTransferWithGarbage(address,uint256,bytes,bytes) (runs: 256, μ: 90189, ~: 83989)
SafeTransferLibTest:testFailTransferWithReturnsFalse() (gas: 8532)
SafeTransferLibTest:testFailTransferWithReturnsFalse(address,uint256,bytes) (runs: 256, μ: 9451, ~: 9446)
SafeTransferLibTest:testFailTransferWithReturnsTooLittle() (gas: 8538)
Expand All @@ -425,12 +425,12 @@ SafeTransferLibTest:testFailTransferWithReturnsTwo(address,uint256,bytes) (runs:
SafeTransferLibTest:testFailTransferWithReverting() (gas: 8494)
SafeTransferLibTest:testFailTransferWithReverting(address,uint256,bytes) (runs: 256, μ: 9350, ~: 9345)
SafeTransferLibTest:testTransferETH() (gas: 34592)
SafeTransferLibTest:testTransferETH(address,uint256,bytes) (runs: 256, μ: 35865, ~: 37975)
SafeTransferLibTest:testTransferETH(address,uint256,bytes) (runs: 256, μ: 35732, ~: 37975)
SafeTransferLibTest:testTransferFromWithGarbage(address,address,uint256,bytes,bytes) (runs: 256, μ: 2907, ~: 2247)
SafeTransferLibTest:testTransferFromWithMissingReturn() (gas: 49186)
SafeTransferLibTest:testTransferFromWithMissingReturn(address,address,uint256,bytes) (runs: 256, μ: 48355, ~: 49598)
SafeTransferLibTest:testTransferFromWithNonContract() (gas: 3035)
SafeTransferLibTest:testTransferFromWithNonContract(address,address,address,uint256,bytes) (runs: 256, μ: 4222, ~: 4228)
SafeTransferLibTest:testTransferFromWithNonContract(address,address,address,uint256,bytes) (runs: 256, μ: 4223, ~: 4228)
SafeTransferLibTest:testTransferFromWithReturnsTooMuch() (gas: 49810)
SafeTransferLibTest:testTransferFromWithReturnsTooMuch(address,address,uint256,bytes) (runs: 256, μ: 49002, ~: 50237)
SafeTransferLibTest:testTransferFromWithStandardERC20() (gas: 47603)
Expand All @@ -439,7 +439,7 @@ SafeTransferLibTest:testTransferWithGarbage(address,uint256,bytes,bytes) (runs:
SafeTransferLibTest:testTransferWithMissingReturn() (gas: 36666)
SafeTransferLibTest:testTransferWithMissingReturn(address,uint256,bytes) (runs: 256, μ: 36001, ~: 37546)
SafeTransferLibTest:testTransferWithNonContract() (gas: 3012)
SafeTransferLibTest:testTransferWithNonContract(address,address,uint256,bytes) (runs: 256, μ: 4185, ~: 4181)
SafeTransferLibTest:testTransferWithNonContract(address,address,uint256,bytes) (runs: 256, μ: 4187, ~: 4181)
SafeTransferLibTest:testTransferWithReturnsTooMuch() (gas: 37112)
SafeTransferLibTest:testTransferWithReturnsTooMuch(address,uint256,bytes) (runs: 256, μ: 36404, ~: 37949)
SafeTransferLibTest:testTransferWithStandardERC20() (gas: 36696)
Expand All @@ -449,11 +449,11 @@ SignedWadMathTest:testFailWadDivZeroDenominator(int256) (runs: 256, μ: 296, ~:
SignedWadMathTest:testFailWadMulOverflow(int256,int256) (runs: 256, μ: 323, ~: 296)
SignedWadMathTest:testWadDiv(uint256,uint256,bool,bool) (runs: 256, μ: 5696, ~: 5664)
SignedWadMathTest:testWadMul(uint256,uint256,bool,bool) (runs: 256, μ: 5720, ~: 5688)
WETHInvariants:invariantTotalSupplyEqualsBalance() (runs: 256, calls: 3840, reverts: 1931)
WETHInvariants:invariantTotalSupplyEqualsBalance() (runs: 256, calls: 3840, reverts: 1929)
WETHTest:testDeposit() (gas: 63535)
WETHTest:testDeposit(uint256) (runs: 256, μ: 62792, ~: 65880)
WETHTest:testFallbackDeposit() (gas: 63249)
WETHTest:testFallbackDeposit(uint256) (runs: 256, μ: 62516, ~: 65604)
WETHTest:testPartialWithdraw() (gas: 73281)
WETHTest:testWithdraw() (gas: 54360)
WETHTest:testWithdraw(uint256,uint256) (runs: 256, μ: 75443, ~: 78076)
WETHTest:testWithdraw(uint256,uint256) (runs: 256, μ: 75443, ~: 78076)
2 changes: 1 addition & 1 deletion lib/ds-test
Open in desktop
Submodule ds-test updated 1 files
+0 −15 package.json
2 changes: 1 addition & 1 deletion src/test/utils/weird-tokens/ReturnsTwoToken.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ contract ReturnsTwoToken {
METADATA STORAGE
//////////////////////////////////////////////////////////////*/

string public constant name = "ReturnsFalseToken";
string public constant name = "ReturnsTwoToken";

string public constant symbol = "RTT";

Expand Down