Add Insufficient Balance and Transfer to Zero Address Checks with Gas Optimization #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
“This is my first contribution to Solmate as part of my journey into smart contract auditing. Feedback welcome!” |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces two custom error checks to improve the ERC20 contract's robustness:
InsufficientBalance: This error is triggered when an account attempts to transfer more tokens than it has in balance.
TransferToZeroAddress: This error prevents users from transferring tokens to the zero address, which could result in lost funds.
Both errors are implemented with gas optimization, ensuring that no unnecessary operations are performed.
Additional Details:
Gas optimization is applied to reduce unnecessary operations, improving overall contract efficiency.
Checklist
Ran forge snapshot?
(Note: Some tests related to snapshots are failing due to existing issues in the repository, unrelated to changes.)
Ran npm run lint=>GOOD
Ran forge test?
(Note: Some tests are failing due to pre-existing issues, not caused by the changes in this PR.)