Skip to content

Conversation

mfelsche
Copy link
Member

Pull request

Description

Related

  • RFC
  • Related Issues: fixes #000, closed #000
  • Related docs PR

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@mfelsche mfelsche added enhancement New feature or request dependencies Pull requests that update a dependency file _complexity:high A task with a high complexity that should be hard _size:humongous A large task that will take a lot of work to complete labels May 21, 2025
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

❌ Patch coverage is 2.56410% with 1596 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.18%. Comparing base (bf45641) to head (6020083).

Files with missing lines Patch % Lines
tremor-script/src/errors.rs 0.00% 464 Missing ⚠️
tremor-script/src/lexer.rs 0.00% 249 Missing ⚠️
...mor-script/src/ast/visitors/impls/args_rewriter.rs 0.00% 75 Missing ⚠️
tremor-pipeline/src/query.rs 0.00% 68 Missing ⚠️
tremor-codec/src/codec/dogstatsd.rs 0.00% 58 Missing ⚠️
tremor-script/src/ast/raw.rs 0.00% 56 Missing ⚠️
tremor-script/src/interpreter/imut_expr.rs 0.00% 56 Missing ⚠️
tremor-value/src/value.rs 0.00% 52 Missing ⚠️
tremor-script/src/registry.rs 0.00% 43 Missing ⚠️
tremor-script/src/ast/deploy/raw.rs 0.00% 35 Missing ⚠️
... and 81 more

❌ Your patch check has failed because the patch coverage (2.56%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (bf45641) and HEAD (6020083). Click for more details.

HEAD has 32 uploads less than BASE
Flag BASE (bf45641) HEAD (6020083)
tremorconnectorstesthelpers 1 0
unittests 17 4
tremorvalue 1 0
e2e-unit 1 0
e2etests 3 0
tremorcodec 1 0
tremorinflux 1 0
e2e-command 1 0
tremorconnectorsgcp 1 0
tremorsystem 1 0
tremorconnectorsobjectstorage 1 0
tremorinterceptor 1 0
tremorpipeline 1 0
tremorapi 1 0
tremorruntime 1 0
tremorscript 1 0
tremorconnectors 1 0
e2e-integration 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2724       +/-   ##
===========================================
- Coverage   91.33%   24.18%   -67.16%     
===========================================
  Files         309      225       -84     
  Lines       60380    33223    -27157     
===========================================
- Hits        55150     8035    -47115     
- Misses       5230    25188    +19958     
Flag Coverage Δ
e2e-command ?
e2e-integration ?
e2e-unit ?
e2etests ?
tremorapi ?
tremorcodec ?
tremorcommon 63.79% <100.00%> (+0.74%) ⬆️
tremorconnectors ?
tremorconnectorsaws 11.11% <0.61%> (-0.12%) ⬇️
tremorconnectorsazure 4.57% <0.80%> (-0.10%) ⬇️
tremorconnectorsgcp ?
tremorconnectorsobjectstorage ?
tremorconnectorsotel 12.28% <1.34%> (-0.25%) ⬇️
tremorconnectorstesthelpers ?
tremorinflux ?
tremorinterceptor ?
tremorpipeline ?
tremorruntime ?
tremorscript ?
tremorsystem ?
tremorvalue ?
unittests 24.18% <2.56%> (-65.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tremor-common/src/ports.rs 24.52% <ø> (-64.37%) ⬇️
tremor-common/src/rand.rs 100.00% <100.00%> (ø)
tremor-common/src/url.rs 82.75% <100.00%> (-4.75%) ⬇️
tremor-config/src/lib.rs 34.78% <ø> (-52.46%) ⬇️
tremor-connectors-azure/src/auth.rs 95.65% <100.00%> (-0.06%) ⬇️
...emor-connectors-azure/src/monitor/ingest/writer.rs 96.04% <100.00%> (+0.37%) ⬆️
...connectors-azure/src/monitor/ingest/writer/sink.rs 57.45% <100.00%> (ø)
tremor-connectors-azure/src/rest.rs 100.00% <100.00%> (ø)
tremor-connectors-object-storage/src/lib.rs 53.94% <ø> (-34.62%) ⬇️
tremor-connectors-otel/src/id.rs 98.92% <100.00%> (ø)
... and 129 more

... and 158 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf45641...6020083. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mfelsche added 3 commits June 5, 2025 21:51
here I left tremor-otelapis etc at their old versions, for the sake of getting ready. This must be tackled in another PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_complexity:high A task with a high complexity that should be hard dependencies Pull requests that update a dependency file enhancement New feature or request _size:humongous A large task that will take a lot of work to complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant