Skip to content

Commit f2e92ae

Browse files
committed
feat(instr-tedious): support tedious@19
https://github.com/tediousjs/tedious/releases/tag/v19.0.0 tedious@19 bumps the min supported Node.js to 18.17.0. Refs: open-telemetry#2400
1 parent de7a6cb commit f2e92ae

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

plugins/node/instrumentation-tedious/.tav.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,10 @@ tedious:
2424
# TypeScript v5 to use. This peerDependencies can be removed when this
2525
# package updates to TypeScript v5.
2626
peerDependencies: typescript@5
27+
- versions:
28+
include: ">=19 <20"
29+
mode: latest-majors
30+
node: '>=18.17'
31+
commands: npm run test
32+
# See typescript@5 note above.
33+
peerDependencies: typescript@5

plugins/node/instrumentation-tedious/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-tedious
1717

1818
## Supported Versions
1919

20-
- [tedious](https://www.npmjs.com/package/tedious) `>=1.11.0 <19`
20+
- [tedious](https://www.npmjs.com/package/tedious) `>=1.11.0 <20`
2121

2222
## Usage
2323

plugins/node/instrumentation-tedious/src/instrumentation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class TediousInstrumentation extends InstrumentationBase<TediousInstrumen
7878
return [
7979
new InstrumentationNodeModuleDefinition(
8080
TediousInstrumentation.COMPONENT,
81-
['>=1.11.0 <19'],
81+
['>=1.11.0 <20'],
8282
(moduleExports: typeof tedious) => {
8383
const ConnectionPrototype: any = moduleExports.Connection.prototype;
8484
for (const method of PATCHED_METHODS) {

plugins/node/instrumentation-tedious/test/instrumentation.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,11 @@ const incompatVersions =
7979
(semver.lt(processVersion, '15.0.0') &&
8080
semver.gte(tediousVersion, '16.0.0')) ||
8181
// tedious@17 removed support for node v16 and v19 https://github.com/tediousjs/tedious/releases/tag/v17.0.0
82-
(semver.lt(processVersion, '17.0.0') && semver.gte(tediousVersion, '17.0.0'));
82+
(semver.lt(processVersion, '17.0.0') &&
83+
semver.gte(tediousVersion, '17.0.0')) ||
84+
// tedious@19 removed support for node <18.17.0 https://github.com/tediousjs/tedious/releases/tag/v19.0.0
85+
(semver.lt(processVersion, '18.17.0') &&
86+
semver.gte(tediousVersion, '19.0.0'));
8387

8488
describe('tedious', () => {
8589
let tedious: any;

0 commit comments

Comments
 (0)