Add session properties configuration

Signed-off-by: Harry <quanghai.ng1512@gmail.com>

Author: sudohainguyen

charts/trino/README.md

@@ -349,6 +349,12 @@ Fast distributed SQL query engine for big data analytics that helps you explore
    - exchange.s3.aws-access-key=your-access-key
    - exchange.s3.aws-secret-key=your-secret-key
   ```
+* `sessionProperties` - object, default: `{}`  
+
+  [Session properties manager config file](https://trino.io/docs/current/admin/session-property-managers.html) is mounted to {{ .Values.server.config.path }}/session-property-config.json
+  Set the type property to either:
+  * `configmap`, and provide the session properties manager file contents in `sessionPropertiesConfig`,
+  * `properties`, and provide configuration properties in `properties`.
 * `eventListenerProperties` - list, default: `[]`  
 
   [Event listener](https://trino.io/docs/current/develop/event-listener.html#event-listener) properties. To configure multiple event listeners, add them in `coordinator.additionalConfigFiles` and `worker.additionalConfigFiles`, and set the `event-listener.config-files` property in `additionalConfigProperties` to their locations.

charts/trino/templates/configmap-coordinator.yaml

@@ -117,6 +117,26 @@ data:
   {{- end }}
 {{- end }}
 
+{{- if .Values.sessionProperties }}
+  {{- if eq .Values.sessionProperties.type "configmap" }}
+  session-property-config.properties: |
+    session-property-config.configuration-manager=file
+    session-property-manager.config-file={{ .Values.server.config.path }}/session-property-config.json
+
+  session-property-config.json: |
+    {{- .Values.sessionProperties.sessionPropertiesConfig | nindent 4 }}
+  {{- else if eq .Values.sessionProperties.type "properties" }}
+  session-property-config.properties: |
+    {{- if .Values.sessionProperties.properties }}
+    {{- .Values.sessionProperties.properties | nindent 4 }}
+    {{- else}}
+    {{- fail "sessionProperties.properties is required when sessionProperties.type is 'properties'." }}
+    {{- end }}
+  {{- else}}
+  {{- fail "Invalid sessionProperties.type value. It must be either 'configmap' or 'properties'." }}
+  {{- end }}
+{{- end }}
+
 {{- if .Values.server.exchangeManager }}
   exchange-manager.properties: |
     exchange-manager.name={{ .Values.server.exchangeManager.name }}

charts/trino/values.yaml

@@ -368,6 +368,50 @@ additionalExchangeManagerProperties: []
 #  - exchange.s3.aws-secret-key=your-secret-key
 # ```
 
+sessionProperties: {}
+# sessionProperties -- [Session properties manager config
+# file](https://trino.io/docs/current/admin/session-property-managers.html) is
+# mounted to {{ .Values.server.config.path }}/session-property-config.json
+# @raw
+# Set the type property to either:
+# * `configmap`, and provide the session properties manager file contents in `sessionPropertiesConfig`,
+# * `properties`, and provide configuration properties in `properties`.
+
+# Properties example:
+# ```yaml
+# type: properties
+# properties: |
+#   session-property-config.configuration-manager=file
+#   session-property-manager.config-file=/etc/trino/session-property-config.json
+
+# Configmap Example:
+# ```yaml
+# type: configmap
+# sessionPropertiesConfig: |-
+#   [
+#     {
+#       "group": "global.*",
+#       "sessionProperties": {
+#         "query_max_execution_time": "8h"
+#       }
+#     },
+#     {
+#       "group": "global.interactive.*",
+#       "sessionProperties": {
+#         "query_max_execution_time": "1h"
+#       }
+#     },
+#     {
+#       "group": "global.pipeline.*",
+#       "clientTags": ["etl"],
+#       "sessionProperties": {
+#         "scale_writers": "true",
+#         "hive.insert_existing_partitions_behavior": "overwrite"
+#       }
+#     }
+#   ]
+# ```
+
 eventListenerProperties: []
 # eventListenerProperties -- [Event
 # listener](https://trino.io/docs/current/develop/event-listener.html#event-listener)

tests/trino/test-values.yaml

@@ -208,6 +208,17 @@ accessControl:
             "user": "alice",
             "owner": false
           }
+        ],
+        "system_session_properties": [
+          {
+            "role": "admin",
+            "allow": true
+          },
+          {
+            "user": ".*",
+            "property": "query_max_execution_time",
+            "allow": true
+          }
         ]
       }
 
@@ -311,6 +322,29 @@ networkPolicy:
               - key: test
                 operator: NotIn
                 values: [network-policy]
+sessionProperties:
+  type: configmap
+  sessionPropertiesConfig: |-
+    [
+      {
+        "group": "global.admin",
+        "sessionProperties": {
+          "query_max_execution_time": "8h"
+        }
+      },
+      {
+        "group": "global.readonly",
+        "sessionProperties": {
+          "query_max_execution_time": "1h"
+        }
+      },
+      {
+        "group": "global.(finance_human_resources|general)",
+        "sessionProperties": {
+          "query_max_execution_time": "10m"
+        }
+      }
+    ]
 
 catalogs:
   tpch: |