Change API introduced in "cuda-python" #849
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mc-nv
force-pushed
the
mchornyi/TPRD-1667/L0_batcher_cudashm
branch
from
b397119 to
e156074
Compare
mc-nv
changed the title
GuanLuo
reviewed
Aug 18, 2025
|
|
||
|
|
||
| def call_cuda_function(function, *argv): | ||
| res = function(*argv) |
Contributor
There was a problem hiding this comment.
Why do you need to change this place? Seems like the difference is where the CUDA function actually gets called (inside v.s. outside call_cuda_function)
Contributor
Author
There was a problem hiding this comment.
I only save my local changes, it's not real change.
I been testing locally and seeking for some specific output.
This is not a working change otherwise PR would be in open state.
yinggeh
reviewed
Aug 18, 2025
src/python/library/tritonclient/utils/cuda_shared_memory/__init__.py
Outdated
Show resolved
Hide resolved
…t__.py Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
krishung5
reviewed
Aug 18, 2025
| call_cuda_function(cudart.cudaSetDevice, device_id) | ||
| device_ptr = call_cuda_function(cudart.cudaMalloc, byte_size) | ||
| cuda_shm_handle = call_cuda_function(cudart.cudaIpcGetMemHandle, device_ptr) | ||
| call_cuda_function(cuda_driver.cuInit(device_id)) |
Contributor
There was a problem hiding this comment.
From the documentation, it looks like we should pass the flags as parameters, not the device id?
https://docs.nvidia.com/cuda/cuda-driver-api/group__CUDA__INITIALIZE.html
Suggested change
| call_cuda_function(cuda_driver.cuInit(device_id)) | |
| call_cuda_function(cuda_driver.cuInit(0)) |
Contributor
Author
|
Closing this change it no longe relevant IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.