fix: Hold GIL when deleting numpy array

kthui · kthui · commit 2082a3c1adfc · 2024-12-10T14:54:43.000-08:00
diff --git a/src/pb_tensor.cc b/src/pb_tensor.cc
@@ -503,6 +503,14 @@ PbTensor::~PbTensor() noexcept(false)
 {
   pb_memory_.reset();
   DeleteDLPack();
+
+#ifdef TRITON_PB_STUB
+  {
+    py::gil_scoped_acquire acquire;
+    py::array numpy_array_local(std::move(numpy_array_));
+    py::array numpy_array_serialized_local(std::move(numpy_array_serialized_));
+  }
+#endif
 }
 
 const std::string&

Original file line number	Diff line number	Diff line change
`@@ -503,6 +503,14 @@ PbTensor::~PbTensor() noexcept(false)`
`503`	`503`	`{`
`504`	`504`	`pb_memory_.reset();`
`505`	`505`	`DeleteDLPack();`
	`506`	`+`
	`507`	`+#ifdef TRITON_PB_STUB`
	`508`	`+ {`
	`509`	`+ py::gil_scoped_acquire acquire;`
	`510`	`+ py::array numpy_array_local(std::move(numpy_array_));`
	`511`	`+ py::array numpy_array_serialized_local(std::move(numpy_array_serialized_));`
	`512`	`+ }`
	`513`	`+#endif`
`506`	`514`	`}`
`507`	`515`
`508`	`516`	`const std::string&`