ci: Improve error handling for Python backend model initialization failures #8303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinggeh
approved these changes
Jul 23, 2025
|
Please add related PRs in description triton-inference-server/python_backend#408 |
yinggeh
approved these changes
Jul 23, 2025
krishung5
reviewed
Jul 23, 2025
| @@ -445,16 +445,6 @@ else | |||
| fi | |||
| fi | |||
|
|
|||
| current_num_pages=`get_shm_pages` | |||
There was a problem hiding this comment.
could you pleas clarify why we need to remove the shm check?
There was a problem hiding this comment.
This test case uncovered a pre-existing bug: the internal SHM in the Python backend is not destroyed when model initialization fails. I have created a follow-up ticket, DLIS-8432, to address this issue. To unblock the current issue, I removed the SHM check that I added earlier. I need to figure it out to address DLIS-8432 separately or as part of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
triton-inference-server/python_backend#408
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)