Add Backend for SpatialHashingCellList #111
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the module file to expose SpatialHashingCellList to the users.
…hashing.jl to correct collision handling. Push collision check in __foreach_neighbor() for better performance. Extend test to test on multiple list sizes. Change plot.jl to test SpatialHashingCellList against the other data structures.
Include SpatialHashingCellList in test/neighborhood_search.jl.
Add check_cell_collision() for benchmarking.
- restore benchmark plotting code - remove NDIMS as a field for SpatialHashingCellList - change evaluation order of cell_collision in foreach_neighbor() to increase efficiency - add small, explicit test for cell collision - clean up
- add comments - adjust version in Project.toml
Move check_cell_bounds() and construct_backends() to separate cell_lists_util.jl to share functionality between different cell lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option for different backends for SpatialHashingCellList.
Please have a look @efaulhaber .