Skip to content

Rename 'tlsph' to 'place_on_shell' #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Rename 'tlsph' to 'place_on_shell' #814

wants to merge 10 commits into from

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented May 22, 2025

Fixes #782

@svchb svchb requested review from efaulhaber and LasNikas May 22, 2025 08:25
@svchb svchb self-assigned this May 22, 2025
@svchb svchb added discussion breaking changes This change will break the public API and requires a new major release labels May 22, 2025
@svchb
Copy link
Collaborator Author

svchb commented May 22, 2025

Other options would be for example:
'place_on_skin'
'place_on_perimeter'
'place_on_face'

@LasNikas
Copy link
Collaborator

place_on_interface ?

@svchb
Copy link
Collaborator Author

svchb commented May 22, 2025

I would like to avoid words that can be used in another context within our setups. Interface could be also the interface between two fluids or phases.

@svchb svchb modified the milestones: 4.0, 0.4 May 22, 2025
@codecov Codecov
Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.74%. Comparing base (618bba5) to head (e8d53a2).

Files with missing lines Patch % Lines
src/setups/extrude_geometry.jl 73.33% 4 Missing ⚠️
src/preprocessing/particle_packing/system.jl 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   70.74%   70.74%           
=======================================
  Files         106      106           
  Lines        6710     6710           
=======================================
  Hits         4747     4747           
  Misses       1963     1963
Flag Coverage Δ
unit 70.74% <80.76%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

efaulhaber
efaulhaber requested changes May 23, 2025
View reviewed changes
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that 👍

@svchb svchb requested a review from efaulhaber May 26, 2025 11:28
@LasNikas
Copy link
Collaborator

LasNikas commented Jun 3, 2025

/run-gpu-tests

efaulhaber
efaulhaber requested changes Jun 3, 2025
View reviewed changes
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this has breaking changes. Revoking my review to make sure we don't merge this by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efaulhaber efaulhaber efaulhaber requested changes

@LasNikas LasNikas LasNikas approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@svchb svchb

Labels
breaking changes This change will break the public API and requires a new major release discussion
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

Find a better name for the packing option tlsph
3 participants
@svchb @LasNikas @efaulhaber