-
Notifications
You must be signed in to change notification settings - Fork 15
Rename 'tlsph' to 'place_on_shell' #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Other options would be for example: |
|
I would like to avoid words that can be used in another context within our setups. Interface could be also the interface between two fluids or phases. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
=======================================
Coverage 70.74% 70.74%
=======================================
Files 106 106
Lines 6710 6710
=======================================
Hits 4747 4747
Misses 1963 1963
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that 👍
/run-gpu-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this has breaking changes. Revoking my review to make sure we don't merge this by accident.
Fixes #782