fix: fix for using input options in ffprobe #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from: fluent-ffmpeg#1317 by @ihorboldysh-xtendx
Input options are currently not passed through to ffprobe. This can be a problem if a URL requires authorization headers. Without the fix ffmepg uses the authorisation headers but ffprobe doesn't.
For example, to have percentages in a progress object, the library uses ffprobe. If the file is protected with authorization, ffprobe couldn't get a file and therefore not report the progress.
Fixes issue fluent-ffmpeg#1146