Make serious FG-BG-WTHH creation exogenous #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementations of endogenous BG and WTHH ID.
hmgaudecker
reviewed
Jul 25, 2025
|
The warning mechanism is still missing and I haven't created the external repo, but the GETTSIM part is pretty much done. You can have a look if you find the time! @hmgaudecker |
hmgaudecker
approved these changes
Jul 25, 2025
This was referenced Jul 26, 2025
hmgaudecker
added a commit
to ttsim-dev/ttsim
that referenced
this pull request
Jul 26, 2025
- As discussed in [GETTSIM #1055](ttsim-dev/gettsim#1055), we sometimes want to fail or issue a warning if a certain node is visited in the graph. This PR adds a mechanism for that along with corresponding tests - Implementation: - All `ColumnObjects` and `ParamFunctions` are endowed with attributes `warn_msg_if_included: str | None = None` and `fail_msg_if_included: str | None = None`. - These are checked by a corresponding fail/warn function each, which depends on the TT DAG and the specialised environment without tree logic and with derived functions (guaranteed to catch the correct type of object) - For warn functions, only unique messages are displayed. E.g., in the GETTSIM example triggering this, we have at least three functions, which all have the same message. - As we visited that code, we realised that `tt_dag` is a better name for `tax_transfer_dag` as we are using that abbreviation much more extensively that 'tax_transfer' by now. Renamed, same for `tax_transfer_function` -> `tt_function`.
hmgaudecker
added a commit
that referenced
this pull request
Jul 26, 2025
- In [TTSIM #16](ttsim-dev/ttsim#16), we implemented a mechanism to raise errors or emit warnings for objects that are part of the TT DAG. - This implements warnings for our prime example motivating that feature, that is, GETTSIM's `bg_id`, `wthh_id`, and `wohngeld_kinderzuschlag_vorrangig_oder_günstiger` functions (see #1055) - It also replaces `NotImplementedErrors` by that mechanism because errors will be collected instead of being raised on-by-one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
Closes #1010