Skip to content

Use fail/warn mechanism for TT DAG elements #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2025
Merged

Use fail/warn mechanism for TT DAG elements #1057

merged 5 commits into from
Jul 26, 2025

Conversation

hmgaudecker
Copy link
Collaborator

@hmgaudecker hmgaudecker commented Jul 26, 2025 •
edited
Loading

  • In TTSIM #16, we implemented a mechanism to raise errors or emit warnings for objects that are part of the TT DAG.
  • This implements warnings for our prime example motivating that feature, that is, GETTSIM's bg_id, wthh_id, and wohngeld_kinderzuschlag_vorrangig_oder_günstiger functions (see Make serious FG-BG-WTHH creation exogenous #1055)
  • It also replaces NotImplementedErrors by that mechanism because errors will be collected instead of being raised on-by-one.

@hmgaudecker hmgaudecker requested a review from MImmesberger July 26, 2025 10:46
@hmgaudecker hmgaudecker merged commit 356cfc4 into main Jul 26, 2025
1 check passed
@hmgaudecker hmgaudecker deleted the warn-if-gettsim-bg_id-wthh_id-functions-are-used branch July 26, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MImmesberger MImmesberger MImmesberger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hmgaudecker @MImmesberger