Skip to content

Conversation

MImmesberger
Copy link
Collaborator

What problem do you want to solve?

Closes #911

@MImmesberger MImmesberger requested a review from hmgaudecker July 26, 2025 12:18
Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer, thanks! Just need to move that one function...

@MImmesberger
Copy link
Collaborator Author

Should we add a new param type in the yamls then? Or just provide the raw function?

@hmgaudecker
Copy link
Collaborator

Should we add a new param type in the yamls then? Or just provide the raw function?

Probably just the function, but that's up to your best judgement. If it seems more similar to those BirthYearBased-things and we are exposing those param types, it may well be the former.

Copy link

codecov bot commented Jul 27, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...gettsim/arbeitslosengeld_2/freibeträge_vermögen.py 20.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hmgaudecker hmgaudecker merged commit 0baeee3 into main Jul 27, 2025
1 of 2 checks passed
@hmgaudecker hmgaudecker deleted the fix-911 branch July 27, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: Define some parameters in ALG2 as a ConsecutiveIntLookupTableParam

2 participants