-
Notifications
You must be signed in to change notification settings - Fork 31
Fix #911 #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #911 #1060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much clearer, thanks! Just need to move that one function...
Should we add a new param type in the yamls then? Or just provide the raw function? |
Probably just the function, but that's up to your best judgement. If it seems more similar to those BirthYearBased-things and we are exposing those param types, it may well be the former. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
for more information, see https://pre-commit.ci
What problem do you want to solve?
Closes #911