Fix taxation of pensions and implement missing parameters of Wachstumschancengesetz #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Codecov report seems like fake news to me, covered through the regression tests in |
hmgaudecker
approved these changes
Sep 13, 2025
This was referenced Sep 13, 2025
|
All of the above was just me trying to fix the docs; realized too late I can just build them locally. Note to self: Need to switch to |
Documentation build overview
Show files changed (5 files in total): 📝 5 modified | ➕ 0 added | ➖ 0 deleted
|
hmgaudecker
approved these changes
Sep 18, 2025
src/gettsim/tests_germany/policy_cases/full_taxes_and_transfers/2019-01-01/hh_id_2.yaml
Show resolved
Hide resolved
src/gettsim/tests_germany/policy_cases/wohngeld/2006-01-01/hh_id_15.yaml
Outdated
Show resolved
Hide resolved
MImmesberger
added a commit
to ttsim-dev/gettsim-personas
that referenced
this pull request
Sep 21, 2025
### What problem do you want to solve? Add the inputs introduced in [1093](ttsim-dev/gettsim#1093).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
This turned from a simple renaming PR to a much larger one. What I changed:
There's one limitation I'm aware of: For each pension type, we have only one input variable. Because the Ertragsanteil depends on the age at which the pension is claimed, we cannot handle cases where someone get's two pensions of the same type, but claimed them in different years. But I doubt this will become relevant any time soon.
I have no good test cases for the taxation of pensions, so I just added some regression tests.