Skip to content

Commit 1401baf

Browse files
committed
Only reiterate failure to create metadata for each node if log level is debug or finer
1 parent 5fb7a05 commit 1401baf

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

graph/src/io/VersionFourMCGReader.cpp

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,13 @@ std::unique_ptr<metacg::Callgraph> metacg::io::VersionFourMCGReader::read() {
179179
auto& mdValJ = mdElem.value();
180180
if (auto md = metacg::MetaData::create<>(mdKey, mdValJ, strToNode); md) {
181181
cg->addEdgeMetaData({nodeData.nodeId, calleeNode->getId()}, std::move(md));
182-
} else if (failedMetadataCb) {
183-
(*failedMetadataCb)(nodeData.nodeId, mdKey, mdValJ);
182+
} else {
183+
if (spdlog::get_level() <= spdlog::level::debug) {
184+
errConsole->warn("Could not create edge metadata of type {} for edge {} to {}", mdKey, nodeData.nodeId, calleeNode->getId());
185+
}
186+
if (failedMetadataCb) {
187+
(*failedMetadataCb)(nodeData.nodeId, mdKey, mdValJ);
188+
}
184189
}
185190
}
186191
}
@@ -192,7 +197,9 @@ std::unique_ptr<metacg::Callgraph> metacg::io::VersionFourMCGReader::read() {
192197
if (auto md = metacg::MetaData::create<>(mdKey, mdVal, strToNode); md) {
193198
node->addMetaData(std::move(md));
194199
} else {
195-
errConsole->warn("Could not create metadata of type {} for node {}", mdKey, node->getFunctionName());
200+
if (spdlog::get_level() <= spdlog::level::debug) {
201+
errConsole->warn("Could not create metadata of type {} for node {}", mdKey, node->getFunctionName());
202+
}
196203
if (failedMetadataCb) {
197204
(*failedMetadataCb)(node->getId(), mdKey, mdVal);
198205
}
@@ -208,7 +215,9 @@ std::unique_ptr<metacg::Callgraph> metacg::io::VersionFourMCGReader::read() {
208215
if (auto md = metacg::MetaData::create<>(mdKey, mdValJ, strToNode); md) {
209216
cg->addMetaData(std::move(md));
210217
} else {
211-
errConsole->warn("Could not create global metadata of type {}", mdKey);
218+
if (spdlog::get_level() <= spdlog::level::debug) {
219+
errConsole->warn("Could not create global metadata of type {}", mdKey);
220+
}
212221
if (failedMetadataCb) {
213222
(*failedMetadataCb)(std::nullopt, mdKey, mdValJ);
214223
}

0 commit comments

Comments
 (0)