Skip to content

Alternative output format when printing the created fixup commits #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arielf212
Copy link
Contributor

@arielf212 arielf212 commented Apr 11, 2025

closes #126

Please read the commit messages, especially the last one:

Do note that if you used the absorb.fixupTargetAlwaysSHA option (or its cli equvalient),
you will see the commit hash instead.

I don't think its interesting enough to fix (maybe this is even the intended behaviour?)

You decide!

This was done sine they are not really helpful to the avarage user,
and take up precious line space that will be used in later commits for better stuff :)
This is more readble by the avarage user, still usable in the git CLI when copy-pasting and saves us a metric ton of precious line space :)
Do note that if you used the absorb.fixupTargetAlwaysSHA option (or its cli equvalient),
you will see the commit hash instead.

I don't think its interesting enough to fix (maybe this is even the intended behaviour?)

You decide!
Copy link
Owner

@tummychow tummychow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the record, i'm fine with the functionality here but likely won't merge it until after #175 . large prs get first dibs on landing so they don't get stuck in rebase hell

let drain = slog_term::FullFormat::new(decorator).build().fuse();
let drain = slog_term::FullFormat::new(decorator)
// Don't write a timestamp, as requested in #126
// I am currently running git absorb myself, I know what time it is :)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no self-explanatory comments please. anyone who wants to know why we did this can blame it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative output format when printing the created fixup commits
2 participants