bump git2/libgit2-sys locked dependencies #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a double free in libgit2 that is fixed somewhere between
v1.0.0 and v1.1.0. This means that the transitive libgit2-sys
dependency needs to be after 0.12.14+1.1.0.
This manifests itself via the following error message on certain
repositories:
$ git absorb
free(): double free detected in tcache 2
Aborted (core dumped)
Bump git2 to the latest version, which also updates the transitive
libgit2-sys (and libgit2) dependency.
Fixes tummychow#69
|
very interesting, thanks for going to the trouble of bisecting the upstream crate version. libgit2/libgit2#5600 corroborates your analysis. (and, since you asked, there is unfortunately no better way i know of to debug an issue like this. i would say you did all the expected steps - retrieved a core dump from the reproducing repo, opened a debugger on the core dump, convinced yourself that it was upstream, and bisected your way through the versions). i will tag a release for this one since it's a pretty severe error for those that encounter it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a double free in libgit2 that is fixed somewhere between v1.0.0 and v1.1.0. This means that the transitive libgit2-sys dependency needs to be after 0.12.14+1.1.0.
This manifests itself via the following error message on certain repositories:
Bump git2 to the latest version, which also updates the transitive libgit2-sys (and libgit2) dependency.
Fixes #69