Instances for Monoidal (,) ()
#194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are ported from #79 where they were needed for traversal-type things. These instances can't hurt. Even though I don't know what we are going to do with traversals yet.
Draft
Divesh-Otwani
approved these changes
Sep 18, 2020
Comment on lines
+47
to
+48
| Kleisli f *** Kleisli g = Kleisli $ \(x,y) -> (,) Control.<$> f x Control.<*> g y | ||
| unit = Kleisli Control.pure |
There was a problem hiding this comment.
Perhaps use -XInstanceSigs and give type signatures for (***) and unit just for readability. It's a bit of a pause figuring out the type in my head. Same for instances below.
There was a problem hiding this comment.
If we are to add instance signatures, we should go over the whole module. So this would be a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are ported from #79 where they were needed for traversal-type
things. These instances can't hurt. Even though I don't know what we
are going to do with traversals yet.