Skip to content

Commit 72b6fa1

Browse files
committed
feat(footnote): resolve comments
1 parent ce7a04b commit 72b6fa1

File tree

8 files changed

+15
-491
lines changed

8 files changed

+15
-491
lines changed

.changeset/quick-feet-rest.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
"@twilio-paste/design-tokens": patch
3-
"@twilio-paste/core": patch
2+
"@twilio-paste/design-tokens": minor
3+
"@twilio-paste/core": minor
44
---
55

66
[Tokens] add shadow-border-bottom

.changeset/slimy-windows-leave.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
"@twilio-paste/footnote": major
3-
"@twilio-paste/core": major
3+
"@twilio-paste/core": minor
44
---
55

66
[Footnote] add new component to reference related information such as a citation.

packages/paste-core/components/footnote/CHANGELOG.md

Lines changed: 0 additions & 483 deletions
Large diffs are not rendered by default.

packages/paste-core/components/footnote/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@twilio-paste/footnote",
3-
"version": "1.0.0",
3+
"version": "0.0.0",
44
"category": "data display",
55
"status": "production",
66
"description": "A Footnote is an inline number that is used within main text to reference related information such as a citation.",

packages/paste-core/components/footnote/src/Footnote.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,18 @@ export interface FootnoteProps extends HTMLPasteProps<"sup"> {
1616
element?: BoxProps["element"];
1717
/**
1818
* The text to display in the tooltip.
19+
*
20+
* @default undefined
21+
* @type {string | undefined}
22+
* @memberof FootnoteProps
1923
*/
2024
tooltipText?: string;
2125
/**
2226
* The content of the footnote, which must be a string.
27+
*
28+
* @default undefined
29+
* @type {string}
30+
* @memberof FootnoteProps
2331
*/
2432
children: string;
2533
}

packages/paste-core/components/footnote/type-docs.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1677,7 +1677,7 @@
16771677
},
16781678
"tooltipText": {
16791679
"type": "string",
1680-
"defaultValue": null,
1680+
"defaultValue": "undefined",
16811681
"required": false,
16821682
"externalProp": false,
16831683
"description": "The text to display in the tooltip."

packages/paste-core/core-bundle/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@
116116
"@twilio-paste/file-picker": "^5.0.2",
117117
"@twilio-paste/file-uploader": "^5.0.2",
118118
"@twilio-paste/flex": "^9.0.1",
119-
"@twilio-paste/footnote": "^1.0.0",
119+
"@twilio-paste/footnote": "^0.0.0",
120120
"@twilio-paste/form": "^12.0.1",
121121
"@twilio-paste/form-pill-group": "^9.0.1",
122122
"@twilio-paste/grid": "^9.0.1",

yarn.lock

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11986,7 +11986,6 @@ __metadata:
1198611986
"@twilio-paste/file-picker": ^5.0.2
1198711987
"@twilio-paste/file-uploader": ^5.0.2
1198811988
"@twilio-paste/flex": ^9.0.1
11989-
"@twilio-paste/footnote": ^1.0.0
1199011989
"@twilio-paste/form": ^12.0.1
1199111990
"@twilio-paste/form-pill-group": ^9.0.1
1199211991
"@twilio-paste/grid": ^9.0.1
@@ -12785,7 +12784,7 @@ __metadata:
1278512784
languageName: unknown
1278612785
linkType: soft
1278712786

12788-
"@twilio-paste/footnote@^1.0.0, @twilio-paste/footnote@workspace:packages/paste-core/components/footnote":
12787+
"@twilio-paste/footnote@workspace:packages/paste-core/components/footnote":
1278912788
version: 0.0.0-use.local
1279012789
resolution: "@twilio-paste/footnote@workspace:packages/paste-core/components/footnote"
1279112790
dependencies:

0 commit comments

Comments
 (0)