Skip to content

chore: update biomejs #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .changeset/lucky-birds-begin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
"@twilio-paste/badge": patch
"@twilio-paste/combobox": patch
"@twilio-paste/core": patch
"@twilio-paste/inline-control-group": patch
"@twilio-paste/page-header": patch
"@twilio-paste/status": patch
"@twilio-paste/box": patch
"@twilio-paste/menu-primitive": patch
"@twilio-paste/text": patch
"@twilio-paste/customization": patch
"@twilio-paste/data-visualization-library": patch
"@twilio-paste/react-textarea-autosize-library": patch
"@twilio-paste/styling-library": patch
"@twilio-paste/theme": patch
---

chore: code formatting updates; no material changes applied
6 changes: 3 additions & 3 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,20 +54,20 @@
"formatter": {
"enabled": true,
"indentStyle": "space",
"indentSize": 2,
"indentWidth": 2,
"lineWidth": 120
},
"javascript": {
"formatter": {
"indentStyle": "space",
"indentSize": 2,
"indentWidth": 2,
"lineWidth": 120
}
},
"json": {
"formatter": {
"indentStyle": "space",
"indentSize": 2,
"indentWidth": 2,
"lineWidth": 120
}
}
Expand Down
5 changes: 1 addition & 4 deletions cypress/support/commands/parent-commands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,7 @@ Cypress.Commands.add("checkInPageNavigationLinks", () => {
cy.get("@pageAsideAnchors").then((anchors) => {
cy.get("@anchoredHeadings").each((anchor, idx) => {
cy.wrap(anchor).should("have.attr", "href").and("include", "#");
cy.wrap(anchors[idx])
.should("have.attr", "href")
.and("include", "#")
.and("eql", anchor.attr("href"));
cy.wrap(anchors[idx]).should("have.attr", "href").and("include", "#").and("eql", anchor.attr("href"));
});
});
});
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"lint:repo": "eslint -c .eslintrc.repo.js --ext .tsx,.ts .",
"format": "biome format ./ && prettier --list-different ./packages/",
"format:write": "biome format ./ --write && prettier ./ --write",
"format:ci": "biome ci ./ --linter-enabled=false && prettier --list-different ./packages/",
"format:ci": "biome ci ./ --linter-enabled=false && prettier --list-different ./packages/",
"type-check": "yarn prebuild && yarn nx run-many --target=tsc",
"tsc": "echo 'Did you mean to run yarn type-check?'",
"chromatic": "chromatic",
Expand All @@ -103,7 +103,7 @@
"@babel/preset-react": "^7.18.6",
"@babel/preset-typescript": "^7.21.4",
"@babel/types": "^7.21.4",
"@biomejs/biome": "1.2.2",
"@biomejs/biome": "^1.6.3",
"@changesets/changelog-github": "^0.2.8",
"@changesets/cli": "^2.13.1",
"@commitlint/cli": "16.2.1",
Expand Down
6 changes: 3 additions & 3 deletions packages/paste-core/components/badge/src/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const badgeBaseStyles: BoxStyleProps = {
};

export const badgeVariantStyles: {
[key in typeof BadgeVariants[number]]: {
[key in (typeof BadgeVariants)[number]]: {
backgroundColor: BoxStyleProps["backgroundColor"];
color: BoxStyleProps["color"];
borderRadius?: BoxStyleProps["borderRadius"];
Expand Down Expand Up @@ -121,7 +121,7 @@ export const badgeVariantStyles: {
};

export const badgeButtonStyles: {
[key in typeof BadgeVariants[number]]: {
[key in (typeof BadgeVariants)[number]]: {
boxShadow: BoxStyleProps["boxShadow"];
};
} = {
Expand Down Expand Up @@ -186,7 +186,7 @@ export const badgeAnchorStyles: BoxStyleProps = {
_focus: { textDecoration: "none", boxShadow: "shadowFocus" },
};

export const getBadgeButtonStyles = (variant: typeof BadgeVariants[number]): BoxStyleProps => {
export const getBadgeButtonStyles = (variant: (typeof BadgeVariants)[number]): BoxStyleProps => {
const variantButtonStyle = badgeButtonStyles[variant];
return {
...variantButtonStyle,
Expand Down
2 changes: 1 addition & 1 deletion packages/paste-core/components/badge/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export type BadgeBaseProps = {
* @type {BadgeVariants}
* @memberof BadgeBaseProps
*/
variant: typeof BadgeVariants[number];
variant: (typeof BadgeVariants)[number];
/**
*
* @default "default"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import * as React from "react";
import { Badge } from "../src";
import type { BadgeVariants } from "../src/constants";

export const makeBadge = (variant: typeof BadgeVariants[number], element?: string): React.ReactElement => (
export const makeBadge = (variant: (typeof BadgeVariants)[number], element?: string): React.ReactElement => (
<Badge as="span" element={element} variant={variant} data-testid={`${variant}_badge`}>
HelloWorld
</Badge>
Expand Down Expand Up @@ -38,7 +38,7 @@ export const getStyles = (element = "BADGE"): { [key: string]: PasteCustomCSS }
};

const CustomizationWrapper: React.FC<
React.PropsWithChildren<{ variant: typeof BadgeVariants[number]; isTestEnvironment: boolean }>
React.PropsWithChildren<{ variant: (typeof BadgeVariants)[number]; isTestEnvironment: boolean }>
> = ({ variant, isTestEnvironment }): React.ReactElement => {
const theme = useTheme();
const customElement = "FOO";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { render, screen } from "@testing-library/react";
import type { RenderOptions } from "@testing-library/react";
import { CustomizationProvider } from "@twilio-paste/customization";
import * as React from "react";
import type { VirtualItem, useVirtual as UseVirtual } from "react-virtual/types";
import type { useVirtual as UseVirtual, VirtualItem } from "react-virtual/types";

import { Combobox } from "../src";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ const ComboboxListboxOption = React.forwardRef<HTMLLIElement, ComboboxListboxOpt
highlighted
? "colorTextPrimary"
: // eslint-disable-next-line unicorn/no-nested-ternary
selected
? "colorTextPrimary"
: "colorText"
selected
? "colorTextPrimary"
: "colorText"
}
display="flex"
justifyContent="space-between"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { render as testRender, screen } from "@testing-library/react";
import { screen, render as testRender } from "@testing-library/react";
import { CustomizationProvider } from "@twilio-paste/customization";
import * as React from "react";

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { BoxProps } from "@twilio-paste/box";
import { Box, safelySpreadBoxProps } from "@twilio-paste/box";
import { Heading } from "@twilio-paste/heading";
import type { HeadingVariants, asTags as AsTags } from "@twilio-paste/heading";
import type { asTags as AsTags, HeadingVariants } from "@twilio-paste/heading";
import type { HTMLPasteProps } from "@twilio-paste/types";
import * as React from "react";

Expand Down
10 changes: 3 additions & 7 deletions packages/paste-core/components/page-header/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
{
"extends": "../../../../tsconfig.json",
"compilerOptions": {
"outDir": "dist/",
"outDir": "dist/"
},
"include": [
"src/**/*",
],
"exclude": [
"node_modules"
]
"include": ["src/**/*"],
"exclude": ["node_modules"]
}
2 changes: 1 addition & 1 deletion packages/paste-core/components/status/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export type StatusBadgeVariants =

export type StatusBadges = {
[key in StatusBadgeVariants]: {
badgeVariant: typeof BadgeVariants[number];
badgeVariant: (typeof BadgeVariants)[number];
icon: React.ReactNode;
color: TextColorOptions;
};
Expand Down
2 changes: 1 addition & 1 deletion packages/paste-core/primitives/box/src/Box.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import {
boxShadow,
compose,
createShouldForwardProp,
props as defaultStylingProps,
flexbox,
grid,
layout,
position,
props as defaultStylingProps,
space,
styled,
typography,
Expand Down
45 changes: 22 additions & 23 deletions packages/paste-core/primitives/menu/__tests__/index.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,29 +10,28 @@ import {
} from "../src";
import type { MenuPrimitiveButtonProps } from "../src";

const PreferencesMenu = React.forwardRef<HTMLButtonElement, MenuPrimitiveButtonProps>(function PreferencesMenu(
props,
ref,
) {
const menu = useMenuPrimitiveState({ baseId: "sub-menu" });
return (
<>
<MenuPrimitiveButton ref={ref} {...menu} {...props} data-testid="example-submenu-trigger">
Preferences
</MenuPrimitiveButton>
<MenuPrimitive {...menu} aria-label="Preferences" data-testid="example-submenu">
<MenuPrimitiveItem {...menu} data-testid="example-submenu-item">
Settings
</MenuPrimitiveItem>
<MenuPrimitiveItem {...menu} disabled data-testid="example-disabled-submenu-item">
Extensions
</MenuPrimitiveItem>
<MenuPrimitiveSeparator {...menu} />
<MenuPrimitiveItem {...menu}>Keyboard shortcuts</MenuPrimitiveItem>
</MenuPrimitive>
</>
);
});
const PreferencesMenu = React.forwardRef<HTMLButtonElement, MenuPrimitiveButtonProps>(
function PreferencesMenu(props, ref) {
const menu = useMenuPrimitiveState({ baseId: "sub-menu" });
return (
<>
<MenuPrimitiveButton ref={ref} {...menu} {...props} data-testid="example-submenu-trigger">
Preferences
</MenuPrimitiveButton>
<MenuPrimitive {...menu} aria-label="Preferences" data-testid="example-submenu">
<MenuPrimitiveItem {...menu} data-testid="example-submenu-item">
Settings
</MenuPrimitiveItem>
<MenuPrimitiveItem {...menu} disabled data-testid="example-disabled-submenu-item">
Extensions
</MenuPrimitiveItem>
<MenuPrimitiveSeparator {...menu} />
<MenuPrimitiveItem {...menu}>Keyboard shortcuts</MenuPrimitiveItem>
</MenuPrimitive>
</>
);
},
);

const MenuMock = (): JSX.Element => {
const menu = useMenuPrimitiveState({ baseId: "menu-example" });
Expand Down
2 changes: 1 addition & 1 deletion packages/paste-core/primitives/text/src/Text.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import {
display,
overflow,
position,
props as stylingProps,
space,
styled,
props as stylingProps,
typography,
verticalAlign,
} from "@twilio-paste/styling-library";
Expand Down
2 changes: 1 addition & 1 deletion packages/paste-customization/src/CustomizationProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Globals as AnimatedGlobals, useReducedMotion } from "@twilio-paste/animation-library";
import { StylingGlobals, ThemeProvider as StyledThemeProvider } from "@twilio-paste/styling-library";
import { ThemeProvider as StyledThemeProvider, StylingGlobals } from "@twilio-paste/styling-library";
import { DarkTheme, DefaultTheme, StyledBase, pasteGlobalStyles } from "@twilio-paste/theme";
import * as React from "react";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,7 @@ export const timeSeriesOptions: Highcharts.Options = {
},
stops: [
[0, Highcharts.getOptions().colors[0]],
[
1,
Highcharts.color(Highcharts.getOptions().colors[0])
.setOpacity(0)
.get("rgba"),
],
[1, Highcharts.color(Highcharts.getOptions().colors[0]).setOpacity(0).get("rgba")],
],
},
marker: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const SIZING_STYLE = [
"wordBreak",
] as const;

type SizingProps = Extract<typeof SIZING_STYLE[number], keyof CSSStyleDeclaration>;
type SizingProps = Extract<(typeof SIZING_STYLE)[number], keyof CSSStyleDeclaration>;

type SizingStyle = Pick<CSSStyleDeclaration, SizingProps>;

Expand Down
78 changes: 40 additions & 38 deletions packages/paste-libraries/styling/src/css-function/css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,51 +196,53 @@ export const responsive = (styles: { [key: string]: any }) => (theme: JSON) => {
return next;
};

export const css = (args: any) => (props = {}): CSSObject => {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
const theme = { ...defaultTheme, ...(props.theme || props) };
let result: { [key: string]: any } = {};
const obj = typeof args === "function" ? args(theme) : args;
const styles = responsive(obj)(theme);

// eslint-disable-next-line guard-for-in,no-restricted-syntax
for (const key in styles) {
const x = styles[key];
const val = typeof x === "function" ? x(theme) : x;

if (key === "variant") {
const variant = css(get(theme, val))(theme);
result = { ...result, ...variant };
// eslint-disable-next-line no-continue
continue;
}
export const css =
(args: any) =>
(props = {}): CSSObject => {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
const theme = { ...defaultTheme, ...(props.theme || props) };
let result: { [key: string]: any } = {};
const obj = typeof args === "function" ? args(theme) : args;
const styles = responsive(obj)(theme);

// eslint-disable-next-line guard-for-in,no-restricted-syntax
for (const key in styles) {
const x = styles[key];
const val = typeof x === "function" ? x(theme) : x;

if (key === "variant") {
const variant = css(get(theme, val))(theme);
result = { ...result, ...variant };
// eslint-disable-next-line no-continue
continue;
}

if (val && typeof val === "object") {
result[key] = css(val)(theme);
// eslint-disable-next-line no-continue
continue;
}
if (val && typeof val === "object") {
result[key] = css(val)(theme);
// eslint-disable-next-line no-continue
continue;
}

const prop = get(aliases, key, key);
const scaleName = get(scales, prop);
const scale = get(theme, scaleName, get(theme, prop, {}));
const transform = get(transforms, prop, get);
const value = transform(scale, val, val);
const prop = get(aliases, key, key);
const scaleName = get(scales, prop);
const scale = get(theme, scaleName, get(theme, prop, {}));
const transform = get(transforms, prop, get);
const value = transform(scale, val, val);

if (multiples[prop]) {
const dirs = multiples[prop];
if (multiples[prop]) {
const dirs = multiples[prop];

for (const dir of dirs) {
result[dir] = value;
for (const dir of dirs) {
result[dir] = value;
}
} else {
result[prop] = value;
}
} else {
result[prop] = value;
}
}

return result;
};
return result;
};

// eslint-disable-next-line import/no-default-export
export default css;
2 changes: 1 addition & 1 deletion packages/paste-theme/src/themeProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Globals as AnimatedGlobals, useReducedMotion } from "@twilio-paste/animation-library";
import {
CacheProvider as EmotionCacheProvider,
StylingGlobals,
ThemeProvider as EmotionThemeProvider,
StylingGlobals,
createCache,
styled,
} from "@twilio-paste/styling-library";
Expand Down
Loading