fix: makes productIcon optional in ProductSwitcherItem #4359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 8def605 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@simpixelated is attempting to deploy a commit to the Twilio Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8def605:
|
...ges/paste-core/components/product-switcher/stories/ProductSwitcher.customization.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: krisantrobus <55083528+krisantrobus@users.noreply.github.com>
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
serifluous
added
the
Area: Components
serifluous
previously approved these changes
Jul 16, 2025
serifluous
added
the
🕵🏻♀️ Run website visual regression
serifluous
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twilio teams (Twilio, Segment, and SendGrid) are updating the design of the unified identity product switcher. Currently, we're hacking in a solution by setting
productIcon={<></>}or similar and passing custom styles to adjust the padding. This works for now, but ideally we should make this property optional for this new use-case.Contributing to Twilio