-
Notifications
You must be signed in to change notification settings - Fork 554
SecureRandom.javaSecuritySecureRandom for two effect types #4338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: series/3.x
Are you sure you want to change the base?
SecureRandom.javaSecuritySecureRandom for two effect types #4338
Conversation
4289911
to
b44494d
Compare
@armanbilge @djspiewak Could you have a look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add some docs to both versions?
Similar to Ref.in
, also I think that in
name is semi standard for this kind of F & G
API: https://typelevel.org/cats-effect/api/3.x/cats/effect/kernel/Ref$.html#in[F[_],G[_],A](a:A)(implicitF:cats.effect.kernel.Sync[F],implicitG:cats.effect.kernel.Sync[G]):F[cats.effect.kernel.Ref[G,A]]
I have added docs. But thinking of .in Im not sure it fits here moreover it would be incompatible and need to release in new MINOR version. I would like to have it in new PATCH |
08fb6b3
to
ce4325a
Compare
ce4325a
to
4bcd1a4
Compare
Unfortunately, adding a new API always breaks forward compatibility, no matter what it's called. We won't be able to get this into a patch, but I've added it to the milestone for the next minor.
Yes, this is a good point. Let's follow this convention. |
Btw, there is probably a workaround: create a |
@dpevunov-cp Do you mind if I take PR and finish it? (as a part of the #4410 ) |
I don't mind but I can try to update PR today |
@geny200 I have updated PR but for some reason some ci build tasks failed and I could not reproduce it locally. Could you take a look please? |
I tried to reproduce it, and and I couldn't either. It looks like a flaky test to me, because this functionality has nothing to do with your changes. Failed job - https://github.com/typelevel/cats-effect/actions/runs/15239205886/job/42857139080?pr=4338 |
Im not sure this is the right and idiomatic way to implement this, but this greatly helps in real app wiring when you have to create instance for some effect G(for example ConnectioIO) when the wiring is done in F(IO for example)
This is my first PR here, please let me know if this should be done somehow differently