fix: respect field-level symbols during query sub-tokenization #2624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass most_weighted_field_symbols_to_index and token_separators to process_tokens - apply ternary logic in process_tokens to fall back to collection-level defaults - ensure sub-tokenization uses field-specific configuration consistently
1 task
kishorenc
approved these changes
Oct 23, 2025
kishorenc
pushed a commit
that referenced
this pull request
Oct 23, 2025
… port of #2624) (#2625) * fix: respect field-level symbols_to_index during query sub-tokenization - pass most_weighted_field_symbols_to_index and token_separators to process_tokens - apply ternary logic in process_tokens to fall back to collection-level defaults - ensure sub-tokenization uses field-specific configuration consistently * test: test sub-tokenization with custom symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The
process_tokens()function was using collection-levelsymbols_to_indexandtoken_separatorsduring sub-tokenization (line 4627), ignoring field-level configuration.most_weighted_field_symbols_to_indexandmost_weighted_field_token_separatorstoprocess_tokens()process_tokens()to use field-level config or fall back to collection defaultsPR Checklist