fix: handle symbols in constraintToString method with array#2027
Open
adrienboulle wants to merge 20 commits intotypestack:developfrom
Open
fix: handle symbols in constraintToString method with array#2027adrienboulle wants to merge 20 commits intotypestack:developfrom
adrienboulle wants to merge 20 commits intotypestack:developfrom
Conversation
Contributor
Author
|
@NoNameProvided would you mind having a look at this PR? |
Contributor
Author
|
@braaar would you mind having a look at this PR? |
Contributor
Author
|
hi @braaar I'm having trouble having this PR reviews, let me know if I'm doing anything wrong I would be more than happy to fix it :) thx a lot! |
Contributor
Author
Contributor
Author
|
@braaar, march 2023 ;) |
Member
|
@adrienboulle could you provide a reproduction of this error in the issue, like I asked? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When implementing custom validators and using array of symbols as constraints, an error is raised when the error message is generated for a failed validation.
Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesFixes
fixes #2026