Skip to content

codly:1.3.1 #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

codly:1.3.1 #2850

wants to merge 2 commits into from

Conversation

Dherse
Copy link
Contributor

@Dherse Dherse commented Aug 5, 2025

I am submitting

  • a new package
  • an update for a package

Description: It's an update to Codly

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@Dherse Dherse temporarily deployed to Package Check August 5, 2025 22:23 — with GitHub Actions Inactive
@Dherse Dherse mentioned this pull request Aug 5, 2025
Merged
@typst-package-check typst-package-check bot added the update A package update. label Aug 5, 2025
@Dherse Dherse temporarily deployed to Package Check August 5, 2025 22:27 — with GitHub Actions Inactive
@saecki saecki self-assigned this Aug 6, 2025
saecki
saecki reviewed Aug 6, 2025
View reviewed changes
Copy link
Member

@saecki saecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! I've left a few comments about the license date and readme examples.

packages/preview/codly/1.3.1/LICENSE
@@ -0,0 +1,21 @@
MIT License

Copyright (c) [2023] [Sébastien d'Herbais de Thun, et al.]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the date here?

packages/preview/codly/1.3.1/README.md

````typ
#import "@preview/codly:1.3.1": *
#import "@preview/codly-languages:0.1.1": *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason this doesn't use the latest release? Ironically I've seen this in a lot of other packages, and this here might be the reason why :)

packages/preview/codly/1.3.1/README.md

You can highlight part of lines using the `highlights` parameters:

````typ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The highlights in this example are offset for me.

packages/preview/codly/1.3.1/README.md
annotations: (
(
start: 2,
end: 4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end value here is different than in the image below.

@saecki saecki added the waiting-on-author Pull request waits on author label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saecki saecki saecki left review comments

Assignees

@saecki saecki

Labels
update A package update. waiting-on-author Pull request waits on author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dherse @saecki