Skip to content

Conversation

cscnk52
Copy link
Contributor

@cscnk52 cscnk52 commented Aug 31, 2025

I am submitting

  • a new package
  • an update for a package

Description: Explain what the package does and why it's useful.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot changed the title sicons: 15.13.0 sicons:15.13.0 Aug 31, 2025
@typst-package-check typst-package-check bot added the update A package update. label Aug 31, 2025
@cscnk52 cscnk52 closed this Sep 2, 2025
@cscnk52 cscnk52 deleted the sicons-15.13.0 branch September 2, 2025 00:41
@cscnk52 cscnk52 restored the sicons-15.13.0 branch September 2, 2025 00:41
@cscnk52 cscnk52 reopened this Sep 2, 2025
@elegaanz elegaanz self-assigned this Sep 2, 2025
@elegaanz
Copy link
Member

elegaanz commented Sep 2, 2025

Because the WASM file powering this package is quite heavy, I think it would be better to not publish updates for every new version of simple icons, but only from time to time, to not bloat this git repository too much. I can still merge this now if you (or someone else) really need the latest version, but otherwise I think it's better to close this PR for now and wait for more changes to accumulate before making another release of the Typst package.

@cscnk52
Copy link
Contributor Author

cscnk52 commented Sep 2, 2025

Yes, you're quite right, I will only update the Typst package once in the future with a big Simple Icons release(About half a year). But this time, please merge it first, because the last version actually didn't work properly due to some of my own oversights of variable name. See cscnk52/typst-sicons#1, and this time I tested locally, it could run properly. Thanks!

@elegaanz
Copy link
Member

elegaanz commented Sep 2, 2025

Okay, thanks for the info.

@elegaanz elegaanz merged commit e789a34 into typst:main Sep 2, 2025
3 checks passed
@cscnk52 cscnk52 deleted the sicons-15.13.0 branch September 2, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update A package update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants