Conversation
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
elegaanz
left a comment
elegaanz
left a comment
There was a problem hiding this comment.
Two little things, but overall looks good to me! Thank you for building this template.
| Issues and pull requests are welcome! If you spot a formatting bug, have a feature idea, or want to pick up something from the [roadmap](ROADMAP.md) — please go for it :) | ||
| Contributions that implement new features are especially appreciated. | ||
|
|
||
| ## License |
There was a problem hiding this comment.
Can you please check that you have the right to distribute the university logo/watermark and if yes, specify under which terms it can be used?
There was a problem hiding this comment.
While the watermark is publicly available on the school's website, I couldn't find anything on its distribution or license. I've removed the watermark from assets and use watermark: none as default. Users can download the watermark from the school website and add it to project instead! Thanks
|
|
||
| Inspired by the [ntu-thesis](https://github.com/tzhuan/ntu-thesis) LaTeX template and follows the official formatting guidelines. The project is named after the iconic Fu Bell on campus. | ||
|
|
||
| ## Quick Start |
There was a problem hiding this comment.
As a suggestion, adding a note about using the template in the web app may be useful too.
There was a problem hiding this comment.
Added a section about using the template in the web app, thanks for the suggestion :)
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
| If you want to add the NTU watermark: | ||
|
|
||
| 1. Download it from the official source: <https://www.lib.ntu.edu.tw/doc/CL/watermark.pdf> | ||
| 2. Convert it to PNG and place it in your project, for example `assets/watermark.png` |
There was a problem hiding this comment.
For info, since Typst 0.14, PDF files can be used as images directly. If you already tried that and the rendering is suboptimal, asking people to convert to manually PNG is a good idea.
There was a problem hiding this comment.
It would also require to change compiler in your typst.toml to "0.14", and wanting to keep compatibility with previous versions is also a good reason to ask for to convert to PNG first.
|
|
||
| 1. Download it from the official source: <https://www.lib.ntu.edu.tw/doc/CL/watermark.pdf> | ||
| 2. Convert it to PNG and place it in your project, for example `assets/watermark.png` | ||
| 3. Set `watermark: "assets/watermark.png"` in `#show: thesis.with(...)` |
There was a problem hiding this comment.
The path would have to be wrapped in an image(...) call, [as explained here][https://github.com/typst/packages/blob/main/docs/resources.md#paths-are-package-scoped).
| acknowledgement-en: include "content/acknowledgement-en.typ", // optional | ||
|
|
||
| bibliography-file: bibliography("refs.bib"), | ||
| watermark: none, // optional: e.g. "assets/watermark.png" (user-provided) |
There was a problem hiding this comment.
The comment here should be updated as well.
| acknowledgement-en: include "sections/acknowledgement-en.typ", | ||
|
|
||
| bibliography-file: bibliography("bibliography/refs.bib"), | ||
| watermark: none, // optional: set to "assets/watermark.png" after adding it locally |
There was a problem hiding this comment.
And here too, to use image(...) in the comment.
There was a problem hiding this comment.
All mentions of "assets/watermark.png" are updated now
confusedkernel
temporarily deployed
to
Package Check
GitHub Actions
Inactive
|
Thank you! |
2 participants
I am submitting
Description: Fubell - An unofficial Typst thesis template for National Taiwan University, designed to comply with the university’s official thesis guidelines.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE