use CompareAndSwap instead of the deprecated CAS shim internally#209
Open
c-tonneslan wants to merge 1 commit into
Open
use CompareAndSwap instead of the deprecated CAS shim internally#209c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
Bool.Toggle and Float32/Float64.Add still called their own deprecated CAS wrappers, which themselves just delegate to CompareAndSwap. Hop straight to CompareAndSwap so the internal code isn't waving its own deprecation warning at the user. Closes uber-go#158 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158.
`Bool.Toggle`, `Float32.Add`/`Sub` and `Float64.Add`/`Sub` were calling their own deprecated `CAS` wrappers, which just delegate to `CompareAndSwap` anyway. Hop straight to `CompareAndSwap` so the internal code isn't waving its own deprecation warning at the next user that runs gopls over the file.