Draft
Conversation
usefulthink
commented
Jan 31, 2023
| * and removing the global `google.maps` object. | ||
| */ | ||
| static unload(): void { | ||
| void this.unloadAsync(); |
Author
There was a problem hiding this comment.
note: this is why I had to disable the no-void eslint rule. Using void here makes it very explicit that it wasn't just accidentally forgotten to return the promise.
BiniCodes
reviewed
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for upcoming changes, this extracts the actual loading of the Google Maps API into a separate class.
The new implementation removes a lot of noise from the GoogleMapsProvider and should have a bit more stability especially considering the React strict-mode (we shouldn't have any more problems with running in strict-mode since actual loading is deferred to catch those problems.
Opened as draft PR for review since it still contains debugging comments and testing is ongoing.