Skip to content

Conversation

@dviererbe
Copy link
Collaborator

@dviererbe dviererbe commented Apr 24, 2025

This PR moves the development, governance, archive-administration articles to a hierarchical structure. This has the benefit that it is visually easier to navigate the articles, because they are grouped and the groups can be toggled to not display.

Without hierarchical toc tree (current state):
image

With hierarchical toc tree (this PR):
image

Additionally this PR removes the anchor/ref markers of article titles. They are not need, because documents can always be referenced by path using the following syntax:

{doc}/path/to/document

or

{doc}Custom link text </path/to/document>

See also: https://github.com/canonical/sphinx-docs-starter-pack/blob/f0723d2831d061a98737c7297598287cb59f805f/docs/reference/doc-cheat-sheet-myst.md?plain=1#L68-L69

In case the article title anchors are wanted, I grouped this change in a separate commit and I can simply drop it.

EDIT: on request of TA I dropped the article title anchors removal

Move the development, governance, archive-administration articles
to a hierarchical structure. This has the benefit that it is visually
easier to navigate the articles, because they are grouped and the
groups can be toggled to not display.

Signed-off-by: Dominik Viererbe <dominik.viererbe@canonical.com>
@dviererbe dviererbe requested a review from s-makin April 24, 2025 10:51
@s-makin
Copy link
Collaborator

s-makin commented Apr 24, 2025

In case the article title anchors are wanted, I grouped this change in a separate commit and I can simply drop it.

Please do drop this change. Using {ref} is always preferable to using {doc}, since ref doesn't rely on specifying a path (which can change if files move).

@dviererbe dviererbe force-pushed the feat/hierarchical-toc-tree branch from ccc381e to 82ee673 Compare April 24, 2025 10:59
Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for restoring the anchors - I expect that many of these pages will be changed/moved/removed/etc when we start to actually migrate content, but I do agree that having the collapsible topics makes the navigation much cleaner. Especially once people start using these docs and become familiar with the conceptual boundaries between the topics.

+1 from me, thanks for doing it :)

@s-makin s-makin merged commit 5823e96 into main Apr 24, 2025
3 checks passed
@dviererbe
Copy link
Collaborator Author

Thanks for the SUPER fast review! ❤️

@dviererbe dviererbe deleted the feat/hierarchical-toc-tree branch April 24, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants